From: Nishanth Menon <nm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 7/9] twl6035: twl6035_i2c_[read|write]_u8 prototype consistent
Date: Fri, 22 Mar 2013 16:33:22 -0500 [thread overview]
Message-ID: <1363988004-25819-8-git-send-email-nm@ti.com> (raw)
In-Reply-To: <1363988004-25819-1-git-send-email-nm@ti.com>
u-boot standard i2c register access prototype is
i2c_read(addr, reg, 1, &buf, 1)
i2c_reg_write(u8 addr, u8 reg, u8 val)
twl6035_i2c_read_u8(u8 addr, u8 *val, u8 reg)
twl6035_i2c_write_u8(u8 addr, u8 val, u8 reg)
does not provide consistency, so switch the prototype to be
consistent with rest of u-boot i2c operations:
twl6035_i2c_read_u8(u8 addr, u8 reg, u8 *val)
twl6035_i2c_write_u8(u8 addr, u8 reg, u8 val)
Signed-off-by: Nishanth Menon <nm@ti.com>
---
include/twl6035.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/twl6035.h b/include/twl6035.h
index 89c2ab5..edc2db5 100644
--- a/include/twl6035.h
+++ b/include/twl6035.h
@@ -37,12 +37,12 @@
#define LDO_MODE_ACTIVE (1 << 0)
/* Functions to read and write from TWL6030 */
-static inline int twl6035_i2c_write_u8(u8 chip_no, u8 val, u8 reg)
+static inline int twl6035_i2c_write_u8(u8 chip_no, u8 reg, u8 val)
{
return i2c_write(chip_no, reg, 1, &val, 1);
}
-static inline int twl6035_i2c_read_u8(u8 chip_no, u8 *val, u8 reg)
+static inline int twl6035_i2c_read_u8(u8 chip_no, u8 reg, u8 *val)
{
return i2c_read(chip_no, reg, 1, val, 1);
}
--
1.7.9.5
next prev parent reply other threads:[~2013-03-22 21:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 21:33 [U-Boot] [PATCH V2 0/9] OMAP3-5: TWL[46]03[05]: cleanup register access and misc minimal cleanups Nishanth Menon
2013-03-22 21:33 ` [U-Boot] [PATCH V2 1/9] twl4030: make twl4030_i2c_write_u8 prototype consistent Nishanth Menon
2013-03-22 21:33 ` [U-Boot] [PATCH V2 2/9] twl4030: make twl4030_i2c_read_u8 " Nishanth Menon
2013-03-22 21:33 ` [U-Boot] [PATCH V2 3/9] twl6030: twl6030_i2c_[read|write]_u8 " Nishanth Menon
2013-03-22 21:33 ` [U-Boot] [PATCH V2 4/9] twl6030: move twl6030 register access functions to common header file Nishanth Menon
2013-03-22 21:33 ` [U-Boot] [PATCH V2 5/9] twl6030: add header guard Nishanth Menon
2013-03-22 21:33 ` [U-Boot] [PATCH V2 6/9] twl6035: make twl6030_i2c_[read|write]_u8 static inline Nishanth Menon
2013-03-22 21:33 ` Nishanth Menon [this message]
2013-03-22 21:33 ` [U-Boot] [PATCH V2 8/9] twl6035: remove redundant palmas_[read|write]_u8 Nishanth Menon
2013-03-22 21:33 ` [U-Boot] [PATCH V2 9/9] twl6035: add header guard Nishanth Menon
2013-03-25 17:47 ` [U-Boot] [PATCH V2 0/9] OMAP3-5: TWL[46]03[05]: cleanup register access and misc minimal cleanups Sricharan R
2013-03-25 18:20 ` Nishanth Menon
2013-03-26 9:31 ` Sricharan R
2013-03-26 13:25 ` Nishanth Menon
2013-03-26 13:34 ` Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363988004-25819-8-git-send-email-nm@ti.com \
--to=nm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox