From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] env: fix potential stack overflow in environment functions
Date: Fri, 5 Apr 2013 18:17:37 -0500 [thread overview]
Message-ID: <1365203857.17535.16@snotra> (raw)
In-Reply-To: <20130405184712.B12A72005BC@gemini.denx.de> (from wd@denx.de on Fri Apr 5 13:47:12 2013)
On 04/05/2013 01:47:12 PM, Wolfgang Denk wrote:
> Dear Rob,
>
> In message <515F1504.4090705@gmail.com> you wrote:
> >
> > >> If the stack is all of RAM, then what address should the initrd
> and dtb
> > >> be copied to?
> > >
> > > Why do they have to be copied at all? Why cannot they remain
> where
> > > they have been loaded in the firtst place? The memcpy just costs
> time,
> > > which is a precious resource. Leave it to the user to find a
> > > reasonable location in RAM where he loads the data, and don't mess
> > > with it.
> >
> > I've got no freaking idea! I do turn that crap off in my environment
> > with initrd_high=0xffffffff. But the default operation is to copy
> it.
>
> Scott, Andy: I think I remember that some architectures really _need_
> LMB - can you please shed a bit ligh on which these are, and why? And
> why it is enabled everywhere?
>
> Also, any information about the underlying design, intended memory map
> etc. would be highly welcome.
CCing Kumar, who added a lot of the lmb stuff -- but it looks like
ramdisk copying predated lmb.
-Scott
next prev parent reply other threads:[~2013-04-05 23:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 21:26 [U-Boot] [PATCH] env: fix potential stack overflow in environment functions Rob Herring
2013-03-22 22:04 ` Wolfgang Denk
2013-03-22 22:56 ` Rob Herring
2013-03-23 0:29 ` Wolfgang Denk
2013-04-03 15:30 ` [U-Boot] " Tom Rini
2013-04-05 11:17 ` Wolfgang Denk
2013-04-05 15:26 ` Rob Herring
2013-04-05 16:15 ` Wolfgang Denk
2013-04-05 16:21 ` Wolfgang Denk
2013-04-05 16:24 ` Wolfgang Denk
2013-04-05 16:40 ` Rob Herring
2013-04-05 17:13 ` Wolfgang Denk
2013-04-05 18:16 ` Rob Herring
2013-04-05 18:47 ` Wolfgang Denk
2013-04-05 23:17 ` Scott Wood [this message]
2013-04-06 7:06 ` Wolfgang Denk
2013-04-05 18:49 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365203857.17535.16@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox