From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [v3] command/cache: Add flush command
Date: Mon, 8 Apr 2013 14:50:20 -0500 [thread overview]
Message-ID: <1365450620.28843.12@snotra> (raw)
In-Reply-To: <20130407082931.1F28B200400@gemini.denx.de> (from wd@denx.de on Sun Apr 7 03:29:31 2013)
On 04/07/2013 03:29:31 AM, Wolfgang Denk wrote:
> Dear sun york-R58495,
>
> In message
> <C707E9F4D8007146BF8DC1424B113AC70B3A435B@039-SN2MPN1-012.039d.mgd.msft.net>
> you wrote:
> >
> > > Can we not split this into:
> > >
> > > dcache flush
> > > icache invalidate
> > >
> > > ? This would make clear what's happening.
> >
> >
> > The idea is to reuse existing code with minimum addition. For the
> applicati
> > ons concerned, these two steps are both needed. Splitting them
> doesn't make
> > things easier.
>
> Reusing code is a Good Thing, but not when it comes at the cost of
> obfucating what the code actually does.
>
> > If I have to use existing command, I'd rather to put these two
> steps under
> > icache invalide <addr> <size>.
>
> No, this is not acceptable. The "icache" command deals with the IC
> only, it must not meddle with the data cache (like flushing it).
I thought you said it was OK to flush more than the user asked for, if
the implementation does not have separate icache/dcache flushes? Why
is it fundamentally different if it's a hardware limitation, or a
limitation of the software layer whose functionality is being exposed?
-Scott
next prev parent reply other threads:[~2013-04-08 19:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 20:50 [U-Boot] [v3] command/cache: Add flush command York Sun
2013-04-05 21:00 ` Tom Rini
2013-04-05 21:09 ` York Sun
2013-04-05 22:09 ` Wolfgang Denk
2013-04-05 23:02 ` York Sun
2013-04-06 7:01 ` Wolfgang Denk
2013-04-07 3:31 ` sun york-R58495
2013-04-07 8:29 ` Wolfgang Denk
2013-04-08 17:45 ` sun york-R58495
2013-04-08 18:35 ` Wolfgang Denk
2013-04-08 19:05 ` Scott Wood
2013-04-08 19:18 ` Wolfgang Denk
2013-04-08 19:31 ` Scott Wood
2013-04-09 17:45 ` Wolfgang Denk
2013-04-10 0:58 ` Scott Wood
2013-04-10 2:07 ` [U-Boot] DWMMC / DWMCI question TigerLiu at viatech.com.cn
2013-04-10 11:58 ` Wolfgang Denk
2013-04-11 1:43 ` TigerLiu at viatech.com.cn
2013-04-10 11:54 ` [U-Boot] [v3] command/cache: Add flush command Wolfgang Denk
2013-04-10 19:42 ` Scott Wood
2013-04-10 21:04 ` Wolfgang Denk
2013-04-10 21:10 ` Scott Wood
2013-04-10 22:50 ` Wolfgang Denk
2013-04-10 23:00 ` Scott Wood
2013-04-11 11:56 ` Wolfgang Denk
2013-04-08 19:50 ` Scott Wood [this message]
2013-04-09 17:48 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365450620.28843.12@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox