From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5][v2] powerpc/mpc85xx: new SPL support for IFC NAND
Date: Mon, 8 Apr 2013 19:55:05 -0500 [thread overview]
Message-ID: <1365468905.28843.30@snotra> (raw)
In-Reply-To: <515F8AA8.9040300@freescale.com> (from prabhakar@freescale.com on Fri Apr 5 21:38:32 2013)
On 04/05/2013 09:38:32 PM, Prabhakar Kushwaha wrote:
> On 04/06/2013 02:10 AM, Scott Wood wrote:
>> On 03/22/2013 02:08:05 AM, Prabhakar Kushwaha wrote:
>>> diff --git a/board/freescale/common/Makefile
>>> b/board/freescale/common/Makefile
>>> index 75725b4..a4d521c 100644
>>> --- a/board/freescale/common/Makefile
>>> +++ b/board/freescale/common/Makefile
>>> @@ -29,6 +29,15 @@ endif
>>>
>>> LIB = $(obj)libfreescale.o
>>>
>>> +MINIMAL=
>>> +
>>> +ifdef CONFIG_SPL_BUILD
>>> +ifdef CONFIG_SPL_INIT_MINIMAL
>>> +MINIMAL=y
>>> +endif
>>> +endif
>>> +
>>> +ifndef MINIMAL
>>> COBJS-$(CONFIG_FSL_CADMUS) += cadmus.o
>>> COBJS-$(CONFIG_FSL_VIA) += cds_via.o
>>> COBJS-$(CONFIG_FMAN_ENET) += fman.o
>>> @@ -62,6 +71,7 @@ SUBLIB-$(CONFIG_P3041DS) +=
>>> p_corenet/libp_corenet.o
>>> SUBLIB-$(CONFIG_P4080DS) += p_corenet/libp_corenet.o
>>> SUBLIB-$(CONFIG_P5020DS) += p_corenet/libp_corenet.o
>>> SUBLIB-$(CONFIG_P5040DS) += p_corenet/libp_corenet.o
>>> +endif
>>>
>>> SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
>>> OBJS := $(addprefix $(obj),$(COBJS-y))
>>
>> If this is needed to avoid pulling in any files from this directory,
>> why did p1_p2_rdb_pc not need this? Is there a particular file that
>> is failing to build or failing to get optimized away
>
> I cannot avoid this directory :(.
> because new SPL compile this directory even after undef QIXIS defines
>
> #ifndef CONFIG_SPL_BUILD
> #define CONFIG_FSL_QIXIS
> #endif
Yeah, the makefiles never see CONFIG_SPL_BUILD -- it only works for C
code.
The P1022 SPL patch just does this in the makefile:
+ifndef CONFIG_SPL_BUILD
COBJS-$(CONFIG_FSL_NGPIXIS) += ngpixis.o
+endif
...which is less intrusive. We can revisit it if we end up actually
needing pixis/qixis inside an SPL.
-Scott
next prev parent reply other threads:[~2013-04-09 0:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 7:08 [U-Boot] [PATCH 2/5][v2] powerpc/mpc85xx: new SPL support for IFC NAND Prabhakar Kushwaha
2013-04-05 20:40 ` Scott Wood
2013-04-06 2:38 ` Prabhakar Kushwaha
2013-04-09 0:55 ` Scott Wood [this message]
2013-04-09 5:04 ` Prabhakar Kushwaha
2013-04-09 21:57 ` Scott Wood
2013-04-09 5:15 ` Prabhakar Kushwaha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365468905.28843.30@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox