From: Egbert Eich <egbert.eich@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/4] fs/fat: Don't multiply fatsize with sector size
Date: Wed, 10 Apr 2013 09:11:55 +0200 [thread overview]
Message-ID: <1365577917-32563-3-git-send-email-egbert.eich@gmail.com> (raw)
In-Reply-To: <1365577917-32563-1-git-send-email-egbert.eich@gmail.com>
From: Egbert Eich <eich@suse.com>
Bugfix:
Here at this place we need the fat size in sectors not bytes.
This was found during code review when adding support for storage
devices with blocksizes != 512.
Signed-off-by: Egbert Eich <eich@suse.com>
---
Changes for v2:
- Coding style fixes.
fs/fat/fat_write.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.c
index b4022aa..fd07240 100644
--- a/fs/fat/fat_write.c
+++ b/fs/fat/fat_write.c
@@ -120,7 +120,6 @@ static int flush_fat_buffer(fsdata *mydata)
__u8 *bufptr = mydata->fatbuf;
__u32 startblock = mydata->fatbufnum * FATBUFBLOCKS;
- fatlength *= mydata->sect_size;
startblock += mydata->fat_sect;
if (getsize > fatlength)
--
1.8.1.4
next prev parent reply other threads:[~2013-04-10 7:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 7:11 [U-Boot] [PATCH v2 0/4] Add Support for Storage Devices with Blocksizes != 512 Egbert Eich
2013-04-10 7:11 ` [U-Boot] [PATCH v2 1/4] disk/iso: Add Support for block sizes > 512 byte to ISO partition support Egbert Eich
2013-05-02 16:07 ` [U-Boot] [U-Boot, v2, " Tom Rini
2013-04-10 7:11 ` Egbert Eich [this message]
2013-05-02 16:07 ` [U-Boot] [U-Boot, v2, 2/4] fs/fat: Don't multiply fatsize with sector size Tom Rini
2013-04-10 7:11 ` [U-Boot] [PATCH v2 3/4] part/dev_desc: Add log2 of blocksize to block_dev_desc data struct Egbert Eich
2013-05-02 16:08 ` [U-Boot] [U-Boot, v2, " Tom Rini
2013-04-10 7:11 ` [U-Boot] [PATCH v2 4/4] fs/ext4: Support device block sizes != 512 bytes Egbert Eich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365577917-32563-3-git-send-email-egbert.eich@gmail.com \
--to=egbert.eich@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox