From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5][v3] board/p1010rdb:Add NAND boot support using new SPL format
Date: Fri, 12 Apr 2013 10:44:45 -0500 [thread overview]
Message-ID: <1365781485.3640.18@snotra> (raw)
In-Reply-To: <516789A8.5060901@freescale.com> (from prabhakar@freescale.com on Thu Apr 11 23:12:24 2013)
On 04/11/2013 11:12:24 PM, Prabhakar Kushwaha wrote:
> On 04/12/2013 01:13 AM, Scott Wood wrote:
>> On 04/11/2013 02:25:22 AM, Prabhakar Kushwaha wrote:
>>> diff --git a/include/configs/P1010RDB.h b/include/configs/P1010RDB.h
>>> index 437ee6e..a6ef276 100644
>>> --- a/include/configs/P1010RDB.h
>>> +++ b/include/configs/P1010RDB.h
>>> @@ -33,6 +33,8 @@
>>>
>>> #ifdef CONFIG_P1010RDB
>>> #define CONFIG_P1010
>>> +#define CONFIG_E500 /* BOOKE e500 family */
>>> +#include <asm/config_mpc85xx.h>
>>> #define CONFIG_NAND_FSL_IFC
>>> #endif
>>
>> Why is this inside the P1010RDB ifdef? Why do we even have a
>> CONFIG_P1010RDB? What other boards use this file
>
> I am supposed to put config_mpc85xx.h after CONFIG_P1010 define.
That doesn't have to mean *immediately* after. :-)
> That's why put under CONFIG_P1010RDB.
> CONFIG_P1010RDB is not being used for P1010 as no other board using
> this file. It can be removed.
>
> Just to guess may be there were plan to add make target for
> P1014(Personality of P1010). but it never happened as it is taken
> care by reading svr.
> I will update it.
OK.
-Scott
prev parent reply other threads:[~2013-04-12 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 7:25 [U-Boot] [PATCH 3/5][v3] board/p1010rdb:Add NAND boot support using new SPL format Prabhakar Kushwaha
2013-04-11 19:43 ` Scott Wood
2013-04-12 4:12 ` Prabhakar Kushwaha
2013-04-12 15:44 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365781485.3640.18@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox