From: Liu Gang <Gang.Liu@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/7] powerpc/boot: Change the macro of Boot from SRIO and PCIE master module
Date: Mon, 6 May 2013 11:28:13 +0800 [thread overview]
Message-ID: <1367810893.4452.3.camel@linux> (raw)
In-Reply-To: <CAKWjMd7Zhv6xy9LCmnhd0Dv8SG_TFmyM0=rTxnjv23+2G3qz6Q@mail.gmail.com>
On Tue, 2013-04-30 at 17:28 -0500, Andy Fleming wrote:
> On Fri, Mar 8, 2013 at 2:41 AM, Liu Gang <Gang.Liu@freescale.com>
> wrote:
> Change the macro "CONFIG_SYS_FSL_SRIO_PCIE_BOOT_MASTER" to
> "CONFIG_SRIO_PCIE_BOOT_MASTER", remove them from
> arch/powerpc/include/asm/config_mpc85xx.h file, and add those
> macros
> in configuration header file of each board which can support
> the
> master module of Boot from SRIO and PCIE.
>
> Signed-off-by: Liu Gang <Gang.Liu@freescale.com>
>
>
>
>
> More important than explaining what the patch does is explaining
> *why*. Why was this change necessary?
>
>
> Make sure the "why" includes what makes this feature a board feature,
> as opposed to an SoC feature?
>
>
> Andy
Thanks, I'll updated the commit message.
And in addition, why the state of the below patch is superseded?
http://patchwork.ozlabs.org/patch/226046/
next prev parent reply other threads:[~2013-05-06 3:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 8:41 [U-Boot] [PATCH 1/7] powerpc/doc: Update the README.srio-pcie-boot-corenet Liu Gang
2013-03-08 8:41 ` [U-Boot] [PATCH 2/7] powerpc/boot: Change the macro of Boot from SRIO and PCIE master module Liu Gang
2013-04-30 22:28 ` Andy Fleming
2013-05-06 3:28 ` Liu Gang [this message]
2013-05-06 18:58 ` Andy Fleming
2013-05-07 8:42 ` Liu Gang
2013-03-08 8:41 ` [U-Boot] [PATCH 3/7] powerpc/b4860qds: Add the tlb entries for SRIO interfaces Liu Gang
2013-03-08 8:41 ` [U-Boot] [PATCH 4/7] powerpc/b4860qds: Enable master module for boot from SRIO and PCIE Liu Gang
2013-03-08 8:41 ` [U-Boot] [PATCH 5/7] powerpc/b4860qds: Slave " Liu Gang
2013-03-08 8:41 ` [U-Boot] [PATCH 6/7] powerpc/t4qds: Enable master module for Boot " Liu Gang
2013-03-08 8:41 ` [U-Boot] [PATCH 7/7] powerpc/t4qds: Slave module for boot " Liu Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367810893.4452.3.camel@linux \
--to=gang.liu@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox