From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT
Date: Fri, 10 May 2013 19:28:46 -0500 [thread overview]
Message-ID: <1368232126.19683.19@snotra> (raw)
In-Reply-To: <20130511000307.C2A093811F7@gemini.denx.de> (from wd@denx.de on Fri May 10 19:03:07 2013)
On 05/10/2013 07:03:07 PM, Wolfgang Denk wrote:
> Dear ying.zhang at freescale.com,
>
> In message <1368182421-859-1-git-send-email-ying.zhang@freescale.com>
> you wrote:
> > From: Ying Zhang <b40530@freescale.com>
> >
> > Add a new symbol CONFIG_SPL_ENV_SUPPORT to replace
> CONFIG_SPL_NET_SUPPORT.
>
> Any CONFIG_* stuff must be documented in the README. Please add this
> documentation.
>
> > In common/Makefile, the environment-related files in SPL is difined
> by
> > CONFIG_SPL_NET_SUPPORT, it is wrong.
>
> s/difined/defined/
>
> Could you please also explain, what exactly is wrong, and how your new
> code fixes this?
We will need the environment in SPL for reasons other than network
support (in particular, hwconfig contains info for how to set up DDR).
Yes, this information should go in the changelog.
-Scott
next prev parent reply other threads:[~2013-05-11 0:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 10:40 [U-Boot] [PATCH] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT ying.zhang at freescale.com
2013-05-11 0:03 ` Wolfgang Denk
2013-05-11 0:28 ` Scott Wood [this message]
2013-05-13 7:19 ` Zhang Ying-B40530
2013-05-13 19:07 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368232126.19683.19@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox