From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Mon, 13 May 2013 09:47:36 -0500
Subject: [U-Boot] [PATCH] powerpc/p1022ds: boot from SD card/SPI flash
	with SPL
In-Reply-To: <B3A295C5BD5B13458B2F5C6AFAD910466E1F76@039-SN2MPN1-021.039d.mgd.msft.net>
	(from B40530@freescale.com on Mon May 13 05:17:40 2013)
References: <1368007463-5760-1-git-send-email-ying.zhang@freescale.com>
	<1368058377.3398.62@snotra>
	<B3A295C5BD5B13458B2F5C6AFAD910466E1F76@039-SN2MPN1-021.039d.mgd.msft.net>
Message-ID: <1368456456.8202.4@snotra>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 05/13/2013 05:17:40 AM, Zhang Ying-B40530 wrote:
> 
> > diff --git a/spl/Makefile b/spl/Makefile
> > index b5a8de7..3a3b868 100644
> > --- a/spl/Makefile
> > +++ b/spl/Makefile
> > @@ -51,6 +51,9 @@ LIBS-y += arch/powerpc/cpu/mpc8xxx/lib8xxx.o
> >  endif
> >  ifeq ($(CPU),mpc85xx)
> >  LIBS-y += arch/powerpc/cpu/mpc8xxx/lib8xxx.o
> > +ifdef CONFIG_SPL_INIT_DDR_SUPPORT
> > +LIBS-y += arch/powerpc/cpu/mpc8xxx/ddr/libddr.o
> > +endif
> 
> Why isn't this handled as part of lib8xxx.o?  We should avoid putting
> hardware-specific things in generic Makefiles.  There ones that are
> already there should be fixed at some point.
> [Zhang Ying]
> Do you mean that all things of the directory "  
> arch/powerpc/cpu/mpc8xxx/ddr "
> will be moved to the directory "arch/powerpc/cpu/mpc8xxx/"?

No.  I meant that arch/powerpc/cpu/mpc8xxx/Makefile should contain the  
LIBS addition for the subdirectory, but apparently it doesn't work that  
way even in non-SPL.  So ignore this; it's more of a future makefile  
cleanup issue.

-Scott