public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] mpc8323erdb: Update crc32 check of MAC
Date: Mon, 13 May 2013 16:31:57 -0400	[thread overview]
Message-ID: <1368477117-32669-4-git-send-email-trini@ti.com> (raw)
In-Reply-To: <1368477117-32669-1-git-send-email-trini@ti.com>

We need to cast to unsigned char, not unsigned short here to avoid a
warning.

Cc: Michael Barkowski <michael.barkowski@freescale.com>
Signed-off-by: Tom Rini <trini@ti.com>
---
 board/freescale/mpc8323erdb/mpc8323erdb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/freescale/mpc8323erdb/mpc8323erdb.c b/board/freescale/mpc8323erdb/mpc8323erdb.c
index f29b2f4..ba4993e 100644
--- a/board/freescale/mpc8323erdb/mpc8323erdb.c
+++ b/board/freescale/mpc8323erdb/mpc8323erdb.c
@@ -195,7 +195,7 @@ int mac_read_from_eeprom(void)
 		printf("\nEEPROM @ 0x%02x read FAILED!!!\n",
 		       CONFIG_SYS_I2C_EEPROM_ADDR);
 	} else {
-		if (crc32(crc, buf, 24) == *(unsigned int *)&buf[24]) {
+		if (crc32(crc, buf, 24) == *(unsigned char *)&buf[24]) {
 			printf("Reading MAC from EEPROM\n");
 			for (i = 0; i < 4; i++) {
 				if (memcmp(&buf[i * 6], "\0\0\0\0\0\0", 6)) {
-- 
1.7.9.5

  parent reply	other threads:[~2013-05-13 20:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13 20:31 [U-Boot] [PATCH 1/4] powerpc: Correct im_dprambase cast Tom Rini
2013-05-13 20:31 ` [U-Boot] [PATCH 2/4] mpc8xx: Correct cast of im_cpm.cp_dparam Tom Rini
2013-05-13 22:34   ` Wolfgang Denk
2013-05-14 10:26     ` Wolfgang Denk
2013-05-15 23:16       ` Scott Wood
2013-05-14 13:14     ` Tom Rini
2013-05-13 20:31 ` [U-Boot] [PATCH 3/4] ELPPC: Don't write magic numbers via short Tom Rini
2013-05-13 22:40   ` Wolfgang Denk
2013-05-13 20:31 ` Tom Rini [this message]
2013-05-13 22:38   ` [U-Boot] [PATCH 4/4] mpc8323erdb: Update crc32 check of MAC Wolfgang Denk
2013-05-13 22:37 ` [U-Boot] [PATCH 1/4] powerpc: Correct im_dprambase cast Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368477117-32669-4-git-send-email-trini@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox