From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 15 May 2013 18:16:01 -0500 Subject: [U-Boot] [PATCH 2/4] mpc8xx: Correct cast of im_cpm.cp_dparam In-Reply-To: <20130514102619.A4E2E3804AF@gemini.denx.de> (from wd@denx.de on Tue May 14 05:26:19 2013) References: <1368477117-32669-1-git-send-email-trini@ti.com> <1368477117-32669-2-git-send-email-trini@ti.com> <20130513223447.5D86C3804AF@gemini.denx.de> <20130514102619.A4E2E3804AF@gemini.denx.de> Message-ID: <1368659761.8202.36@snotra> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/14/2013 05:26:19 AM, Wolfgang Denk wrote: > Dear Tom, > > In message <20130513223447.5D86C3804AF@gemini.denx.de> I wrote: > > > > In message <1368477117-32669-2-git-send-email-trini@ti.com> you > wrote: > > > We must cast this to unsigned char not unsigned short to avoid > warnings. > > > > But this is wrong. We're actually reading a 16 bit value here. > > > > I think there was previous discussion, and Scott Wodd has a patch > out > > there, which just needed some minor fixing... > > Scott's patch is here: > > http://patchwork.ozlabs.org/patch/210599/ > > Scott, do you have any plans to submit an updated version? I'll try to get to it soon. -Scott