public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Henrik Nordström" <henrik@henriknordstrom.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] ARM v7: Flush icache when executing a program with go
Date: Tue, 21 May 2013 23:57:21 +0200	[thread overview]
Message-ID: <1369173441.29955.9.camel@localhost> (raw)
In-Reply-To: <20130521122601.6D9BA384809@gemini.denx.de>

tis 2013-05-21 klockan 14:26 +0200 skrev Wolfgang Denk:

> > but imho the user shouldn't really need to care for these and is why I
> > hooked into the go command.
> 
> In this case you should use the common C API.

Unfortunately the go command do now know what range(s) it needs to
flush.

> No.  bootm  knows exactly the location and size of the image, so it is
> sufficient to flush / invalidate a part of the memory, usually a
> pretty small one compared to the total RAM size.

See arch/arm/cpu/armv7/cpu.c cleaup_before_linux() for what I am talking
about regarding bootm.

> > And I do not think there needs to be commands for flushing specific
> > regions other than for testing. Region based flushing is better done by
> > code which knows what is needed. It's hard for users to get this right
> > as most times it works anyway.
> 
> The code should know which ranges need flushing, not the user.

Agreed. But I don't see how this can be done for go.

Should we instrument all the load commands to remember which ranges
something have been loaded into since last flush?

Regards
Henrik

  reply	other threads:[~2013-05-21 21:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14 14:16 [U-Boot] ARM v7: Flush icache when executing a program with go Henrik Nordström
2013-05-15 15:11 ` Albert ARIBAUD
2013-05-15 16:34   ` Henrik Nordström
2013-05-15 16:44     ` Albert ARIBAUD
2013-05-15 16:51       ` Tom Rini
2013-05-15 17:39         ` Albert ARIBAUD
2013-05-16  1:54           ` Henrik Nordström
2013-05-16  7:14             ` Wolfgang Denk
2013-05-16 13:37               ` Tom Rini
2013-05-16 15:37                 ` Henrik Nordström
2013-05-16 22:13                   ` Wolfgang Denk
2013-05-17 12:16                     ` Henrik Nordström
2013-05-20  0:55                       ` Kuo-Jung Su
2013-05-21 12:37                         ` Wolfgang Denk
2013-05-21 12:26                       ` Wolfgang Denk
2013-05-21 21:57                         ` Henrik Nordström [this message]
2013-05-21 12:38                   ` Kees Jongenburger
2013-05-21 16:45                     ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369173441.29955.9.camel@localhost \
    --to=henrik@henriknordstrom.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox