From: Rob Herring <robherring2@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/7] ahci: use ports implemented map instead of num_ports
Date: Tue, 21 May 2013 17:44:30 -0500 [thread overview]
Message-ID: <1369176276-1895-1-git-send-email-robherring2@gmail.com> (raw)
From: Richard Gibbs <richard.gibbs@calxeda.com>
The AHCI driver was incorrectly using the Capabilities register NP (number
of ports) field to determine which ports to activate. This commit changes
it to correctly use the PORTS_IMPL register as a port map.
Signed-off-by: Richard Gibbs <richard.gibbs@calxeda.com>
---
drivers/block/ahci.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c
index cab7f8c..b89be06 100644
--- a/drivers/block/ahci.c
+++ b/drivers/block/ahci.c
@@ -136,6 +136,7 @@ static int ahci_host_init(struct ahci_probe_ent *probe_ent)
u32 tmp, cap_save, cmd;
int i, j;
volatile u8 *port_mmio;
+ u32 port_map;
debug("ahci_host_init: start\n");
@@ -177,6 +178,7 @@ static int ahci_host_init(struct ahci_probe_ent *probe_ent)
#endif
probe_ent->cap = readl(mmio + HOST_CAP);
probe_ent->port_map = readl(mmio + HOST_PORTS_IMPL);
+ port_map = probe_ent->port_map;
probe_ent->n_ports = (probe_ent->cap & 0x1f) + 1;
debug("cap 0x%x port_map 0x%x n_ports %d\n",
@@ -186,6 +188,8 @@ static int ahci_host_init(struct ahci_probe_ent *probe_ent)
probe_ent->n_ports = CONFIG_SYS_SCSI_MAX_SCSI_ID;
for (i = 0; i < probe_ent->n_ports; i++) {
+ if (!(port_map & (1 << i)))
+ continue;
probe_ent->port[i].port_mmio = ahci_port_base((u32) mmio, i);
port_mmio = (u8 *) probe_ent->port[i].port_mmio;
ahci_setup_port(&probe_ent->port[i], (unsigned long)mmio, i);
--
1.8.1.2
next reply other threads:[~2013-05-21 22:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 22:44 Rob Herring [this message]
2013-05-21 22:44 ` [U-Boot] [PATCH 2/7] ahci: fix unaligned access Rob Herring
2013-05-24 13:45 ` Tom Rini
2013-05-24 18:35 ` Wolfgang Denk
2013-05-21 22:44 ` [U-Boot] [PATCH 3/7] ahci: fix memory leak in ata_scsiop_inquiry Rob Herring
2013-05-24 13:46 ` Tom Rini
2013-05-21 22:44 ` [U-Boot] [PATCH 4/7] ahci: move link bring-up handling to separate function Rob Herring
2013-05-24 13:44 ` Tom Rini
2013-05-21 22:44 ` [U-Boot] [PATCH 5/7] ahci: handle COMINIT received during spin-up Rob Herring
2013-05-24 13:47 ` Tom Rini
2013-05-21 22:44 ` [U-Boot] [PATCH 6/7] ahci: increase spin-up timeout to 20 sec Rob Herring
2013-05-24 13:51 ` Tom Rini
2013-05-21 22:44 ` [U-Boot] [PATCH 7/7] ahci: convert to use libata functions and definitions Rob Herring
2013-05-24 13:53 ` Tom Rini
2013-05-24 13:45 ` [U-Boot] [PATCH 1/7] ahci: use ports implemented map instead of num_ports Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369176276-1895-1-git-send-email-robherring2@gmail.com \
--to=robherring2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox