public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rob Herring <robherring2@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/7] ahci: handle COMINIT received during spin-up
Date: Tue, 21 May 2013 17:44:34 -0500	[thread overview]
Message-ID: <1369176276-1895-5-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1369176276-1895-1-git-send-email-robherring2@gmail.com>

From: Rob Herring <rob.herring@calxeda.com>

Some Intel SSDs can send a COMINIT after the initial COMRESET. This causes
the link to go down and we need to re-initialize the link.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
 drivers/block/ahci.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c
index 79710ef..5ffdf95 100644
--- a/drivers/block/ahci.c
+++ b/drivers/block/ahci.c
@@ -260,8 +260,19 @@ static int ahci_host_init(struct ahci_probe_ent *probe_ent)
 			if (!(tmp & (ATA_STAT_BUSY | ATA_STAT_DRQ)))
 				break;
 			udelay(1000);
+			tmp = readl(port_mmio + PORT_SCR_STAT) & 0xf;
+			if (tmp == 0x1)
+				break;
 			j++;
 		}
+
+		tmp = readl(port_mmio + PORT_SCR_STAT) & 0xf;
+		if (tmp == 0x1) {
+			debug("SATA link %d down (COMINIT received), retrying...\n", i);
+			i--;
+			continue;
+		}
+
 		printf("Target spinup took %d ms.\n", j);
 		if (j == WAIT_MS_SPINUP)
 			debug("timeout.\n");
-- 
1.8.1.2

  parent reply	other threads:[~2013-05-21 22:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 22:44 [U-Boot] [PATCH 1/7] ahci: use ports implemented map instead of num_ports Rob Herring
2013-05-21 22:44 ` [U-Boot] [PATCH 2/7] ahci: fix unaligned access Rob Herring
2013-05-24 13:45   ` Tom Rini
2013-05-24 18:35   ` Wolfgang Denk
2013-05-21 22:44 ` [U-Boot] [PATCH 3/7] ahci: fix memory leak in ata_scsiop_inquiry Rob Herring
2013-05-24 13:46   ` Tom Rini
2013-05-21 22:44 ` [U-Boot] [PATCH 4/7] ahci: move link bring-up handling to separate function Rob Herring
2013-05-24 13:44   ` Tom Rini
2013-05-21 22:44 ` Rob Herring [this message]
2013-05-24 13:47   ` [U-Boot] [PATCH 5/7] ahci: handle COMINIT received during spin-up Tom Rini
2013-05-21 22:44 ` [U-Boot] [PATCH 6/7] ahci: increase spin-up timeout to 20 sec Rob Herring
2013-05-24 13:51   ` Tom Rini
2013-05-21 22:44 ` [U-Boot] [PATCH 7/7] ahci: convert to use libata functions and definitions Rob Herring
2013-05-24 13:53   ` Tom Rini
2013-05-24 13:45 ` [U-Boot] [PATCH 1/7] ahci: use ports implemented map instead of num_ports Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369176276-1895-5-git-send-email-robherring2@gmail.com \
    --to=robherring2@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox