[U-Boot] [PATCH] powerpc/mpc85xx:Add iprot input arg in create_TLB0/1_entry

Scott Wood
2013-06-04T16:37:45Z

On 06/04/2013 11:36:17 AM, Scott Wood wrote:
> On 06/04/2013 05:24:41 AM, Prabhakar Kushwaha wrote:
>> create_tlb1_entry and create_tlb0_entry creates TLB entries with
>> IPROT
>> bit set by default. Any TLB entries with IPROT = 1 can not be
>> invalidated.
>>
>> Add IPROT as input argument for TLB entry creation APIs.
>>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
>> ---
>> Based upon git://git.denx.de/u-boot.git branch master
>
> NACK as discussed in the thread where you suggested this.

Sigh, didn't notice this was the external list, so I'll elaborate. We
never want to create a non-IPROT entry, as we don't have a TLB miss
handler that will replace entries that have been invalidated. This
will be especially important if we ever run U-Boot inside a virtual
machine. And yes, this means that the current TLB0 usage should go
away as well.

-Scott