From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Tue, 4 Jun 2013 11:48:43 -0500 Subject: [U-Boot] bug, nand, am33xx: nand->ecc.strength not set in board_nand_init() In-Reply-To: <1370335952-14086-1-git-send-email-hs@denx.de> (from hs@denx.de on Tue Jun 4 03:52:32 2013) References: <1370335952-14086-1-git-send-email-hs@denx.de> Message-ID: <1370364523.748.3@snotra> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/04/2013 03:52:32 AM, Heiko Schocher wrote: > commit dfe64e2c89731a3f9950d7acd8681b68df2bae03 > Author: Sergey Lapin > Date: Mon Jan 14 03:46:50 2013 +0000 > > mtd: resync with Linux-3.7.1 > > Introduced runtime bug: > > U-Boot 2013.04-00499-g46567df-dirty (Jun 04 2013 - 08:17:08) > > I2C: ready > DRAM: 512 MiB > WARNING: Caches not enabled > NAND: BUG: failure at nand_base.c:3214/nand_scan_tail()! > BUG! > resetting ... > > on boards using drivers/mtd/nand/omap_gpmc.c as in board_nand_init() > nand->ecc.strength is not set. Fix this! Thanks, applied to u-boot-nand-flash. We did try to update all the existing drivers to do this. Omap_gpmc did get updated, but it was incomplete, as unlike most drivers, it has two different places where this stuff gets initialized (the actual init, and the ecc switch command). -Scott