From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 5 Jun 2013 13:35:18 -0500 Subject: [U-Boot] [PATCH] powerpc/mpc85xx:Add iprot input arg in create_TLB0/1_entry In-Reply-To: <51AEAE86.3090000@freescale.com> (from prabhakar@freescale.com on Tue Jun 4 22:20:38 2013) References: <1370341481-10468-1-git-send-email-prabhakar@freescale.com> <1370363777.748.1@snotra> <1370363865.748.2@snotra> <51AEAE86.3090000@freescale.com> Message-ID: <1370457318.26139.4@snotra> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/04/2013 10:20:38 PM, Prabhakar Kushwaha wrote: > On 06/04/2013 10:07 PM, Scott Wood wrote: >> On 06/04/2013 11:36:17 AM, Scott Wood wrote: >>> On 06/04/2013 05:24:41 AM, Prabhakar Kushwaha wrote: >>>> create_tlb1_entry and create_tlb0_entry creates TLB entries with >>>> IPROT >>>> bit set by default. Any TLB entries with IPROT = 1 can not be >>>> invalidated. >>>> >>>> Add IPROT as input argument for TLB entry creation APIs. >>>> >>>> Signed-off-by: Prabhakar Kushwaha >>>> --- >>>> Based upon git://git.denx.de/u-boot.git branch master >>> >>> NACK as discussed in the thread where you suggested this. >> >> Sigh, didn't notice this was the external list, so I'll elaborate. >> We never want to create a non-IPROT entry, as we don't have a TLB >> miss handler that will replace entries that have been invalidated. >> This will be especially important if we ever run U-Boot inside a >> virtual machine. And yes, this means that the current TLB0 usage >> should go away as well. > > oh.. > > this means function like invalidate_tlb(1) should not be used u-boot? Pretty much, yes. -Scott