* [U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din
@ 2013-06-11 13:57 Axel Lin
2013-06-11 14:49 ` Simon Glass
2013-06-13 17:32 ` [U-Boot] " Jagan Teki
0 siblings, 2 replies; 6+ messages in thread
From: Axel Lin @ 2013-06-11 13:57 UTC (permalink / raw)
To: u-boot
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/spi/armada100_spi.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/spi/armada100_spi.c b/drivers/spi/armada100_spi.c
index afdbe05..b237c7c 100644
--- a/drivers/spi/armada100_spi.c
+++ b/drivers/spi/armada100_spi.c
@@ -182,15 +182,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout,
goto done;
}
- if (dout)
- pss->tx = dout;
- else
- pss->tx = NULL;
-
- if (din)
- pss->rx = din;
- else
- pss->rx = NULL;
+ pss->tx = dout;
+ pss->rx = din;
if (flags & SPI_XFER_BEGIN) {
spi_cs_activate(slave);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din
2013-06-11 13:57 [U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din Axel Lin
@ 2013-06-11 14:49 ` Simon Glass
2013-06-12 8:38 ` Marek Vasut
2013-06-13 17:32 ` [U-Boot] " Jagan Teki
1 sibling, 1 reply; 6+ messages in thread
From: Simon Glass @ 2013-06-11 14:49 UTC (permalink / raw)
To: u-boot
On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin <axel.lin@ingics.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> drivers/spi/armada100_spi.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/spi/armada100_spi.c b/drivers/spi/armada100_spi.c
> index afdbe05..b237c7c 100644
> --- a/drivers/spi/armada100_spi.c
> +++ b/drivers/spi/armada100_spi.c
> @@ -182,15 +182,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int
> bitlen, const void *dout,
> goto done;
> }
>
> - if (dout)
> - pss->tx = dout;
> - else
> - pss->tx = NULL;
> -
> - if (din)
> - pss->rx = din;
> - else
> - pss->rx = NULL;
> + pss->tx = dout;
> + pss->rx = din;
>
> if (flags & SPI_XFER_BEGIN) {
> spi_cs_activate(slave);
> --
> 1.8.1.2
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din
2013-06-11 14:49 ` Simon Glass
@ 2013-06-12 8:38 ` Marek Vasut
2013-06-12 10:19 ` Ajay Bhargav
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2013-06-12 8:38 UTC (permalink / raw)
To: u-boot
Dear Simon Glass,
> On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin <axel.lin@ingics.com> wrote:
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din
2013-06-12 8:38 ` Marek Vasut
@ 2013-06-12 10:19 ` Ajay Bhargav
2013-06-12 19:04 ` Jagan Teki
0 siblings, 1 reply; 6+ messages in thread
From: Ajay Bhargav @ 2013-06-12 10:19 UTC (permalink / raw)
To: u-boot
----- "Marek Vasut" <marex@denx.de> wrote:
> Dear Simon Glass,
>
> > On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin <axel.lin@ingics.com>
> wrote:
> > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> >
> > Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Reviewed-by: Marek Vasut <marex@denx.de>
>
Acked-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
Regards,
Ajay Bhargav
---------------------------------------------------------------------------------------------
Notice:
This message has been scanned by Trend Micro Mail Security scanner and is believed to be clean
---------------------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din
2013-06-12 10:19 ` Ajay Bhargav
@ 2013-06-12 19:04 ` Jagan Teki
0 siblings, 0 replies; 6+ messages in thread
From: Jagan Teki @ 2013-06-12 19:04 UTC (permalink / raw)
To: u-boot
On 12-06-2013 15:49, Ajay Bhargav wrote:
>
> ----- "Marek Vasut" <marex@denx.de> wrote:
>
>> Dear Simon Glass,
>>
>>> On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin <axel.lin@ingics.com>
>> wrote:
>>>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>>>
>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>
>> Reviewed-by: Marek Vasut <marex@denx.de>
>>
> Acked-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
>
> Regards,
> Ajay Bhargav
>
> ---------------------------------------------------------------------------------------------
> Notice:
> This message has been scanned by Trend Micro Mail Security scanner and is believed to be clean
> ---------------------------------------------------------------------------------------------
>
Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
--
Thanks,
Jagan.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] spi: armada100_spi: Remove unnecessary NULL test for dout and din
2013-06-11 13:57 [U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din Axel Lin
2013-06-11 14:49 ` Simon Glass
@ 2013-06-13 17:32 ` Jagan Teki
1 sibling, 0 replies; 6+ messages in thread
From: Jagan Teki @ 2013-06-13 17:32 UTC (permalink / raw)
To: u-boot
On 11-06-2013 19:27, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Reviewed-by: Marek Vasut <marex@denx.de>
> Acked-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
>
> ---
> drivers/spi/armada100_spi.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/spi/armada100_spi.c b/drivers/spi/armada100_spi.c
> index afdbe05..b237c7c 100644
> --- a/drivers/spi/armada100_spi.c
> +++ b/drivers/spi/armada100_spi.c
> @@ -182,15 +182,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout,
> goto done;
> }
>
> - if (dout)
> - pss->tx = dout;
> - else
> - pss->tx = NULL;
> -
> - if (din)
> - pss->rx = din;
> - else
> - pss->rx = NULL;
> + pss->tx = dout;
> + pss->rx = din;
>
> if (flags & SPI_XFER_BEGIN) {
> spi_cs_activate(slave);
>
Applied to u-boot-spi/master
--
Thanks,
Jagan.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-06-13 17:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-11 13:57 [U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din Axel Lin
2013-06-11 14:49 ` Simon Glass
2013-06-12 8:38 ` Marek Vasut
2013-06-12 10:19 ` Ajay Bhargav
2013-06-12 19:04 ` Jagan Teki
2013-06-13 17:32 ` [U-Boot] " Jagan Teki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox