From: Axel Lin <axel.lin@ingics.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] spi: cf_spi: Question about checking (dspi->sr & 0x0000F000) witch magic number 4
Date: Sat, 15 Jun 2013 00:55:25 +0800 [thread overview]
Message-ID: <1371228925.4087.2.camel@phoenix> (raw)
Hi,
While reading the code in cfspi_tx():
while ((dspi->sr & 0x0000F000) >= 4) ;
I don't see the point of checking "(dspi->sr & 0x0000F000) >= 4)".
I'm wondering if it should be
while ((dspi->sr & 0x0000F000) >> 12) >= 4) ;
or simply
while (dspi->sr & 0x0000F000) ;
Current code actually has the same effect as "while (dspi->sr & 0x0000F000) ;".
comments?
Axel
reply other threads:[~2013-06-14 16:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371228925.4087.2.camel@phoenix \
--to=axel.lin@ingics.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox