From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/p1022ds: nand: introduce the TPL based on the SPL
Date: Mon, 17 Jun 2013 19:11:57 -0500 [thread overview]
Message-ID: <1371514317.9073.9@snotra> (raw)
In-Reply-To: <B3A295C5BD5B13458B2F5C6AFAD9104671EAE2@039-SN2MPN1-021.039d.mgd.msft.net> (from B40530@freescale.com on Mon Jun 17 02:56:45 2013)
On 06/17/2013 02:56:45 AM, Zhang Ying-B40530 wrote:
>
>
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Saturday, June 15, 2013 12:37 AM
> To: Zhang Ying-B40530
> Cc: Wood Scott-B07421; u-boot at lists.denx.de; afleming at gmail.com; Xie
> Xiaobo-R63061
> Subject: Re: [PATCH] powerpc/p1022ds: nand: introduce the TPL based
> on the SPL
>
> On 06/14/2013 05:08:49 AM, Zhang Ying-B40530 wrote:
> >
> >
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, June 14, 2013 5:50 AM
> > To: Zhang Ying-B40530
> > Cc: Wood Scott-B07421; u-boot at lists.denx.de; afleming at gmail.com; Xie
> > Xiaobo-R63061
> > Subject: Re: [PATCH] powerpc/p1022ds: nand: introduce the TPL based
> > on the SPL
> >
> > Treat the autoconf.mk patch as a dependency. Don't try to hack
> around
> > its absence.
> > [Zhang Ying]
> > According to what you said, the same set of symbols will be declared
> > under different ifdefs.
> > That's the trouble, "The same set of symbols declared under
> different
> > ifdefs" will not be effective in the "Makefile", in the current
> case.
>
> It *will* be effective in the makefile if there is a separate
> autoconf.mk for each phase. My point is that a separate autoconf.mk
> for each phase is a requirement for TPL to be done in a sane way.
> [Zhang Ying]
> So, could you tell me where I do wrong? Please let me know the
> specific.
> Thanks.
Do not create a whole bunch of CONFIG_TPL_... definitions. Base your
patches on top of the patch that creates a separate autoconf.mk.
-Scott
prev parent reply other threads:[~2013-06-18 0:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 5:54 [U-Boot] [PATCH] powerpc/p1022ds: nand: introduce the TPL based on the SPL ying.zhang at freescale.com
2013-06-12 22:28 ` Scott Wood
2013-06-13 7:27 ` Zhang Ying-B40530
2013-06-13 21:49 ` Scott Wood
2013-06-14 10:08 ` Zhang Ying-B40530
2013-06-14 16:37 ` Scott Wood
2013-06-17 7:56 ` Zhang Ying-B40530
2013-06-18 0:11 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371514317.9073.9@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox