From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] nand onfi 8bit/16bit bus support
Date: Wed, 19 Jun 2013 12:17:21 -0500 [thread overview]
Message-ID: <1371662241.9073.35@snotra> (raw)
In-Reply-To: <51C1B4C3.1060701@monstr.eu> (from monstr@monstr.eu on Wed Jun 19 08:40:19 2013)
On 06/19/2013 08:40:19 AM, Michal Simek wrote:
> Hi Scott,
>
> On 05/09/2013 11:37 PM, Scott Wood wrote:
> > On 05/06/2013 11:53:52 AM, Michal Simek wrote:
> >> Hi guys,
> >>
> >> Zynq supports 8 and 16bit ONFI nand flashes.
> >> We can count number of connected pins and from that
> >> we know if 8bit or 16bit nand flash is used.
> >>
> >> I have looked at the code and contains ONFI detection
> >> with correct detection of bus width + checking later.
> >> Why also not setup proper chip->options for NAND_BUSWIDTH_16?
> >>
> >> Not sure how others but if driver expect just ONFI devices
> >> and support 8 and 16bit options why not just to setup
> >> chip options based on information from ONFI or
> >> not check that (busw != (chip->options & NAND_BUSWIDTH_16))
> >> for onfi case.
> >
> > This is fixed in current Linux, with NAND_BUSWIDTH_AUTO. There was
> a patchset to merge in recent Linux MTD code a while back, but an
> expected respin didn't come. I'll try to fix it up when I process
> this merge window's patches.
>
> Have you done this change?
> I have grepped the latest version and I can't see it there.
MTD from 3.7.1 (which was what was current when the patch was posted
months ago) was merged in. It looks like NAND_BUSWIDTH_AUTO was added
in 3.8. We can do another MTD update in the next merge window, which
would pick this up. Or if you'd like to submit a patch that just fixes
this problem (in the same way as in Linux, so it doesn't conflict too
badly when we do the merge), it could be applied now as a bugfix.
-Scott
next prev parent reply other threads:[~2013-06-19 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 16:53 [U-Boot] nand onfi 8bit/16bit bus support Michal Simek
2013-05-09 21:37 ` Scott Wood
2013-05-10 5:57 ` Michal Simek
2013-06-19 13:40 ` Michal Simek
2013-06-19 17:17 ` Scott Wood [this message]
2013-06-20 5:32 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371662241.9073.35@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox