public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@ingics.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation
Date: Thu, 20 Jun 2013 15:13:39 +0800	[thread overview]
Message-ID: <1371712419.4200.1.camel@phoenix> (raw)

In current gpio_set_value() implementation, it always sets the gpio control bit
no matter the value argument is 0 or 1. Thus the GPIOs never set to low.
This patch fixes this bug.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/gpio/spear_gpio.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/spear_gpio.c b/drivers/gpio/spear_gpio.c
index d3c728e..8878608 100644
--- a/drivers/gpio/spear_gpio.c
+++ b/drivers/gpio/spear_gpio.c
@@ -52,7 +52,10 @@ int gpio_set_value(unsigned gpio, int value)
 {
 	struct gpio_regs *regs = (struct gpio_regs *)CONFIG_GPIO_BASE;
 
-	writel(1 << gpio, &regs->gpiodata[DATA_REG_ADDR(gpio)]);
+	if (value)
+		writel(1 << gpio, &regs->gpiodata[DATA_REG_ADDR(gpio)]);
+	else
+		writel(0, &regs->gpiodata[DATA_REG_ADDR(gpio)]);
 
 	return 0;
 }
-- 
1.8.1.2

             reply	other threads:[~2013-06-20  7:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20  7:13 Axel Lin [this message]
2013-06-20  7:22 ` [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation Stefan Roese
2013-06-20 13:09 ` Michael Trimarchi
2013-06-20 13:57   ` Marek Vasut
2013-06-20 15:04     ` Michael Trimarchi
2013-06-20 15:11       ` Marek Vasut
2013-06-20 13:44 ` Marek Vasut
2013-06-20 13:56   ` Axel Lin
2013-06-20 20:02     ` Michael Trimarchi
2013-06-20 20:16       ` Marek Vasut
2013-06-21  4:40     ` Vipin Kumar
2013-06-21  6:42       ` Michael Trimarchi
2013-06-30  4:18         ` Axel Lin
2013-06-30  8:10           ` Michael Trimarchi
2013-06-30  8:57             ` Axel Lin
2013-07-01  4:27               ` Vipin Kumar
2013-07-01  5:32                 ` Axel Lin
2013-07-01  6:21                   ` Vipin Kumar
2013-08-12 16:57                     ` Axel Lin
2013-08-12 17:00                       ` Michael Trimarchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371712419.4200.1.camel@phoenix \
    --to=axel.lin@ingics.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox