public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs
Date: Fri, 21 Jun 2013 15:59:38 -0500	[thread overview]
Message-ID: <1371848378.11064.31@snotra> (raw)
In-Reply-To: <20130621203848.GD11333@right.am.freescale.net> (from afleming@freescale.com on Fri Jun 21 15:38:48 2013)

On 06/21/2013 03:38:48 PM, Andy Fleming wrote:
> On Thu, Jun 13, 2013 at 10:14:00AM +0530, Prabhakar Kushwaha wrote:
> > init_tlbs() initialize all the TLB entries required for the system.
> >
> > So disable DEBUG TLB entry before TLB entries initialization.
> >
> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> 
> Applied, with fixes.
> 
> > diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c  
> b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> > index f4403c2..340b063 100644
> > --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> > +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> > @@ -180,5 +180,9 @@ void cpu_init_early_f(void)
> >
> >  	invalidate_tlb(1);
> >
> > +#if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) &&  
> !defined(CONFIG_SPL_BUILD)
> > +	disable_tlb(CONFIG_SYS_PPC_E500_DEBUG_TLB);
> > +#endif
> 
> Had to add CONFIG_NAND_SPL here, as well, just for future reference

Why exclude all SPLs?  Only minimal SPLs skip creating the debug TLB.

-Scott

  reply	other threads:[~2013-06-21 20:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13  4:44 [U-Boot] [PATCH][v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs Prabhakar Kushwaha
2013-06-21 20:38 ` [U-Boot] [U-Boot, v2] " Andy Fleming
2013-06-21 20:59   ` Scott Wood [this message]
2013-06-21 21:05     ` Fleming Andy-AFLEMING
2013-06-21 21:12       ` Scott Wood
2013-06-24  3:14         ` Prabhakar Kushwaha
2013-06-24  6:17           ` Prabhakar Kushwaha
2013-06-24 17:41             ` Scott Wood
2013-06-25  4:37               ` Prabhakar Kushwaha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371848378.11064.31@snotra \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox