* [U-Boot] [PATCH][v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs @ 2013-06-13 4:44 Prabhakar Kushwaha 2013-06-21 20:38 ` [U-Boot] [U-Boot, v2] " Andy Fleming 0 siblings, 1 reply; 9+ messages in thread From: Prabhakar Kushwaha @ 2013-06-13 4:44 UTC (permalink / raw) To: u-boot init_tlbs() initialize all the TLB entries required for the system. So disable DEBUG TLB entry before TLB entries initialization. Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> --- changes for v2: Fixed checkpatch warning. arch/powerpc/cpu/mpc85xx/cpu_init_early.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c index f4403c2..340b063 100644 --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c @@ -180,5 +180,9 @@ void cpu_init_early_f(void) invalidate_tlb(1); +#if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && !defined(CONFIG_SPL_BUILD) + disable_tlb(CONFIG_SYS_PPC_E500_DEBUG_TLB); +#endif + init_tlbs(); } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [U-Boot, v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs 2013-06-13 4:44 [U-Boot] [PATCH][v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs Prabhakar Kushwaha @ 2013-06-21 20:38 ` Andy Fleming 2013-06-21 20:59 ` Scott Wood 0 siblings, 1 reply; 9+ messages in thread From: Andy Fleming @ 2013-06-21 20:38 UTC (permalink / raw) To: u-boot On Thu, Jun 13, 2013 at 10:14:00AM +0530, Prabhakar Kushwaha wrote: > init_tlbs() initialize all the TLB entries required for the system. > > So disable DEBUG TLB entry before TLB entries initialization. > > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> Applied, with fixes. > diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c > index f4403c2..340b063 100644 > --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c > +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c > @@ -180,5 +180,9 @@ void cpu_init_early_f(void) > > invalidate_tlb(1); > > +#if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && !defined(CONFIG_SPL_BUILD) > + disable_tlb(CONFIG_SYS_PPC_E500_DEBUG_TLB); > +#endif Had to add CONFIG_NAND_SPL here, as well, just for future reference ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [U-Boot, v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs 2013-06-21 20:38 ` [U-Boot] [U-Boot, v2] " Andy Fleming @ 2013-06-21 20:59 ` Scott Wood 2013-06-21 21:05 ` Fleming Andy-AFLEMING 0 siblings, 1 reply; 9+ messages in thread From: Scott Wood @ 2013-06-21 20:59 UTC (permalink / raw) To: u-boot On 06/21/2013 03:38:48 PM, Andy Fleming wrote: > On Thu, Jun 13, 2013 at 10:14:00AM +0530, Prabhakar Kushwaha wrote: > > init_tlbs() initialize all the TLB entries required for the system. > > > > So disable DEBUG TLB entry before TLB entries initialization. > > > > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> > > Applied, with fixes. > > > diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c > b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c > > index f4403c2..340b063 100644 > > --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c > > +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c > > @@ -180,5 +180,9 @@ void cpu_init_early_f(void) > > > > invalidate_tlb(1); > > > > +#if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && > !defined(CONFIG_SPL_BUILD) > > + disable_tlb(CONFIG_SYS_PPC_E500_DEBUG_TLB); > > +#endif > > Had to add CONFIG_NAND_SPL here, as well, just for future reference Why exclude all SPLs? Only minimal SPLs skip creating the debug TLB. -Scott ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [U-Boot, v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs 2013-06-21 20:59 ` Scott Wood @ 2013-06-21 21:05 ` Fleming Andy-AFLEMING 2013-06-21 21:12 ` Scott Wood 0 siblings, 1 reply; 9+ messages in thread From: Fleming Andy-AFLEMING @ 2013-06-21 21:05 UTC (permalink / raw) To: u-boot On Jun 21, 2013, at 3:59 PM, Scott Wood wrote: > On 06/21/2013 03:38:48 PM, Andy Fleming wrote: >> On Thu, Jun 13, 2013 at 10:14:00AM +0530, Prabhakar Kushwaha wrote: >> > init_tlbs() initialize all the TLB entries required for the system. >> > >> > So disable DEBUG TLB entry before TLB entries initialization. >> > >> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> >> Applied, with fixes. >> > diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >> > index f4403c2..340b063 100644 >> > --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >> > +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >> > @@ -180,5 +180,9 @@ void cpu_init_early_f(void) >> > >> > invalidate_tlb(1); >> > >> > +#if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && !defined(CONFIG_SPL_BUILD) >> > + disable_tlb(CONFIG_SYS_PPC_E500_DEBUG_TLB); >> > +#endif >> Had to add CONFIG_NAND_SPL here, as well, just for future reference > > Why exclude all SPLs? Only minimal SPLs skip creating the debug TLB. The definition of disable_tlb() is excluded when NAND_SPL is defined. It may be that the error lies the other way around, but this fixed my build problem. Andy ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [U-Boot, v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs 2013-06-21 21:05 ` Fleming Andy-AFLEMING @ 2013-06-21 21:12 ` Scott Wood 2013-06-24 3:14 ` Prabhakar Kushwaha 0 siblings, 1 reply; 9+ messages in thread From: Scott Wood @ 2013-06-21 21:12 UTC (permalink / raw) To: u-boot On 06/21/2013 04:05:37 PM, Fleming Andy-AFLEMING wrote: > > On Jun 21, 2013, at 3:59 PM, Scott Wood wrote: > > > On 06/21/2013 03:38:48 PM, Andy Fleming wrote: > >> On Thu, Jun 13, 2013 at 10:14:00AM +0530, Prabhakar Kushwaha wrote: > >> > init_tlbs() initialize all the TLB entries required for the > system. > >> > > >> > So disable DEBUG TLB entry before TLB entries initialization. > >> > > >> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> > >> Applied, with fixes. > >> > diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c > b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c > >> > index f4403c2..340b063 100644 > >> > --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c > >> > +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c > >> > @@ -180,5 +180,9 @@ void cpu_init_early_f(void) > >> > > >> > invalidate_tlb(1); > >> > > >> > +#if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && > !defined(CONFIG_SPL_BUILD) > >> > + disable_tlb(CONFIG_SYS_PPC_E500_DEBUG_TLB); > >> > +#endif > >> Had to add CONFIG_NAND_SPL here, as well, just for future reference > > > > Why exclude all SPLs? Only minimal SPLs skip creating the debug > TLB. > > The definition of disable_tlb() is excluded when NAND_SPL is defined. I'm talking about new-SPL, not NAND_SPL. My comment is about the original patch (I made the comment before internally), not your edit to it. -Scott ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [U-Boot, v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs 2013-06-21 21:12 ` Scott Wood @ 2013-06-24 3:14 ` Prabhakar Kushwaha 2013-06-24 6:17 ` Prabhakar Kushwaha 0 siblings, 1 reply; 9+ messages in thread From: Prabhakar Kushwaha @ 2013-06-24 3:14 UTC (permalink / raw) To: u-boot On 06/22/2013 02:42 AM, Scott Wood wrote: > On 06/21/2013 04:05:37 PM, Fleming Andy-AFLEMING wrote: >> >> On Jun 21, 2013, at 3:59 PM, Scott Wood wrote: >> >> > On 06/21/2013 03:38:48 PM, Andy Fleming wrote: >> >> On Thu, Jun 13, 2013 at 10:14:00AM +0530, Prabhakar Kushwaha wrote: >> >> > init_tlbs() initialize all the TLB entries required for the system. >> >> > >> >> > So disable DEBUG TLB entry before TLB entries initialization. >> >> > >> >> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> >> >> Applied, with fixes. >> >> > diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >> b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >> >> > index f4403c2..340b063 100644 >> >> > --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >> >> > +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >> >> > @@ -180,5 +180,9 @@ void cpu_init_early_f(void) >> >> > >> >> > invalidate_tlb(1); >> >> > >> >> > +#if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && >> !defined(CONFIG_SPL_BUILD) >> >> > + disable_tlb(CONFIG_SYS_PPC_E500_DEBUG_TLB); >> >> > +#endif >> >> Had to add CONFIG_NAND_SPL here, as well, just for future reference >> > >> > Why exclude all SPLs? Only minimal SPLs skip creating the debug TLB. >> >> The definition of disable_tlb() is excluded when NAND_SPL is defined. > > I'm talking about new-SPL, not NAND_SPL. My comment is about the > original patch (I made the comment before internally), not your edit > to it. > as per comment from Scott, we should have below define. It takes care of SPL minimal + nand_spl #if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && !defined(CONFIG_SPL_INIT_MINIMAL) && !defined(CONFIG_NAND_SPL) May I resend this patch? Regards, Prabhakar ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [U-Boot, v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs 2013-06-24 3:14 ` Prabhakar Kushwaha @ 2013-06-24 6:17 ` Prabhakar Kushwaha 2013-06-24 17:41 ` Scott Wood 0 siblings, 1 reply; 9+ messages in thread From: Prabhakar Kushwaha @ 2013-06-24 6:17 UTC (permalink / raw) To: u-boot On 06/24/2013 08:44 AM, Prabhakar Kushwaha wrote: > On 06/22/2013 02:42 AM, Scott Wood wrote: >> On 06/21/2013 04:05:37 PM, Fleming Andy-AFLEMING wrote: >>> >>> On Jun 21, 2013, at 3:59 PM, Scott Wood wrote: >>> >>> > On 06/21/2013 03:38:48 PM, Andy Fleming wrote: >>> >> On Thu, Jun 13, 2013 at 10:14:00AM +0530, Prabhakar Kushwaha wrote: >>> >> > init_tlbs() initialize all the TLB entries required for the >>> system. >>> >> > >>> >> > So disable DEBUG TLB entry before TLB entries initialization. >>> >> > >>> >> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> >>> >> Applied, with fixes. >>> >> > diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>> b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>> >> > index f4403c2..340b063 100644 >>> >> > --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>> >> > +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>> >> > @@ -180,5 +180,9 @@ void cpu_init_early_f(void) >>> >> > >>> >> > invalidate_tlb(1); >>> >> > >>> >> > +#if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && >>> !defined(CONFIG_SPL_BUILD) >>> >> > + disable_tlb(CONFIG_SYS_PPC_E500_DEBUG_TLB); >>> >> > +#endif >>> >> Had to add CONFIG_NAND_SPL here, as well, just for future reference >>> > >>> > Why exclude all SPLs? Only minimal SPLs skip creating the debug TLB. >>> >>> The definition of disable_tlb() is excluded when NAND_SPL is defined. >> >> I'm talking about new-SPL, not NAND_SPL. My comment is about the >> original patch (I made the comment before internally), not your edit >> to it. >> > as per comment from Scott, we should have below define. It takes care > of SPL minimal + nand_spl > > #if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && > !defined(CONFIG_SPL_INIT_MINIMAL) && !defined(CONFIG_NAND_SPL) > > May I resend this patch? > > just a afterthought, current modified* patch is correct i.e. " #if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && !defined(CONFIG_SPL_BUILD) && !defined(CONFIG_NAND_SPL)" DEBUG TLB never been created for SPL & NAND_SPL so no need to disable. Regards, Prabhakar ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [U-Boot, v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs 2013-06-24 6:17 ` Prabhakar Kushwaha @ 2013-06-24 17:41 ` Scott Wood 2013-06-25 4:37 ` Prabhakar Kushwaha 0 siblings, 1 reply; 9+ messages in thread From: Scott Wood @ 2013-06-24 17:41 UTC (permalink / raw) To: u-boot On 06/24/2013 01:17:11 AM, Prabhakar Kushwaha wrote: > On 06/24/2013 08:44 AM, Prabhakar Kushwaha wrote: >> On 06/22/2013 02:42 AM, Scott Wood wrote: >>> On 06/21/2013 04:05:37 PM, Fleming Andy-AFLEMING wrote: >>>> >>>> On Jun 21, 2013, at 3:59 PM, Scott Wood wrote: >>>> >>>> > On 06/21/2013 03:38:48 PM, Andy Fleming wrote: >>>> >> On Thu, Jun 13, 2013 at 10:14:00AM +0530, Prabhakar Kushwaha >>>> wrote: >>>> >> > init_tlbs() initialize all the TLB entries required for the >>>> system. >>>> >> > >>>> >> > So disable DEBUG TLB entry before TLB entries initialization. >>>> >> > >>>> >> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> >>>> >> Applied, with fixes. >>>> >> > diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>>> b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>>> >> > index f4403c2..340b063 100644 >>>> >> > --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>>> >> > +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>>> >> > @@ -180,5 +180,9 @@ void cpu_init_early_f(void) >>>> >> > >>>> >> > invalidate_tlb(1); >>>> >> > >>>> >> > +#if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && >>>> !defined(CONFIG_SPL_BUILD) >>>> >> > + disable_tlb(CONFIG_SYS_PPC_E500_DEBUG_TLB); >>>> >> > +#endif >>>> >> Had to add CONFIG_NAND_SPL here, as well, just for future >>>> reference >>>> > >>>> > Why exclude all SPLs? Only minimal SPLs skip creating the debug >>>> TLB. >>>> >>>> The definition of disable_tlb() is excluded when NAND_SPL is >>>> defined. >>> >>> I'm talking about new-SPL, not NAND_SPL. My comment is about the >>> original patch (I made the comment before internally), not your >>> edit to it. >>> >> as per comment from Scott, we should have below define. It takes >> care of SPL minimal + nand_spl >> >> #if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && >> !defined(CONFIG_SPL_INIT_MINIMAL) && !defined(CONFIG_NAND_SPL) >> >> May I resend this patch? It would need to be: #if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && \ !(defined(CONFIG_SPL_INIT_MINIMAL) && defined(CONFIG_SPL_BUILD)) && \ !defined(CONFIG_NAND_SPL) > just a afterthought, current modified* patch is correct i.e. " #if > defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && !defined(CONFIG_SPL_BUILD) > && !defined(CONFIG_NAND_SPL)" > DEBUG TLB never been created for SPL & NAND_SPL so no need to disable. Why would the debug TLB not be created for a non-minimal-init SPL? -Scott ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [U-Boot, v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs 2013-06-24 17:41 ` Scott Wood @ 2013-06-25 4:37 ` Prabhakar Kushwaha 0 siblings, 0 replies; 9+ messages in thread From: Prabhakar Kushwaha @ 2013-06-25 4:37 UTC (permalink / raw) To: u-boot On 06/24/2013 11:11 PM, Scott Wood wrote: > On 06/24/2013 01:17:11 AM, Prabhakar Kushwaha wrote: >> On 06/24/2013 08:44 AM, Prabhakar Kushwaha wrote: >>> On 06/22/2013 02:42 AM, Scott Wood wrote: >>>> On 06/21/2013 04:05:37 PM, Fleming Andy-AFLEMING wrote: >>>>> >>>>> On Jun 21, 2013, at 3:59 PM, Scott Wood wrote: >>>>> >>>>> > On 06/21/2013 03:38:48 PM, Andy Fleming wrote: >>>>> >> On Thu, Jun 13, 2013 at 10:14:00AM +0530, Prabhakar Kushwaha >>>>> wrote: >>>>> >> > init_tlbs() initialize all the TLB entries required for the >>>>> system. >>>>> >> > >>>>> >> > So disable DEBUG TLB entry before TLB entries initialization. >>>>> >> > >>>>> >> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> >>>>> >> Applied, with fixes. >>>>> >> > diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>>>> b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>>>> >> > index f4403c2..340b063 100644 >>>>> >> > --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>>>> >> > +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>>>> >> > @@ -180,5 +180,9 @@ void cpu_init_early_f(void) >>>>> >> > >>>>> >> > invalidate_tlb(1); >>>>> >> > >>>>> >> > +#if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && >>>>> !defined(CONFIG_SPL_BUILD) >>>>> >> > + disable_tlb(CONFIG_SYS_PPC_E500_DEBUG_TLB); >>>>> >> > +#endif >>>>> >> Had to add CONFIG_NAND_SPL here, as well, just for future >>>>> reference >>>>> > >>>>> > Why exclude all SPLs? Only minimal SPLs skip creating the debug >>>>> TLB. >>>>> >>>>> The definition of disable_tlb() is excluded when NAND_SPL is defined. >>>> >>>> I'm talking about new-SPL, not NAND_SPL. My comment is about the >>>> original patch (I made the comment before internally), not your >>>> edit to it. >>>> >>> as per comment from Scott, we should have below define. It takes >>> care of SPL minimal + nand_spl >>> >>> #if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && >>> !defined(CONFIG_SPL_INIT_MINIMAL) && !defined(CONFIG_NAND_SPL) >>> >>> May I resend this patch? > > It would need to be: > > #if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && \ > !(defined(CONFIG_SPL_INIT_MINIMAL) && defined(CONFIG_SPL_BUILD)) && \ > !defined(CONFIG_NAND_SPL) > >> just a afterthought, current modified* patch is correct i.e. " #if >> defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && !defined(CONFIG_SPL_BUILD) >> && !defined(CONFIG_NAND_SPL)" >> DEBUG TLB never been created for SPL & NAND_SPL so no need to disable. > > Why would the debug TLB not be created for a non-minimal-init SPL? > Looks like my assumption is *wrong*. as per this define #if defined(CONFIG_NAND_SPL) || \ (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_INIT_MINIMAL)) #define MINIMAL_SPL #endif MINIMAL_SPL is defined only with CONFIG_SPL_INIT_MINIMAL. for MINIMAL_SPL interrupt vectors are never relocated. hence, no need of DEBUG TLB entry. for rest, interrupt vectors are relocated, so debug tlb entry is must. I will post a patch upstream to fix this problem. Thanks, Prabhakar ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-06-25 4:37 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-06-13 4:44 [U-Boot] [PATCH][v2] powerpc/mpc85xx:Disable Debug TLB entry before init_tlbs Prabhakar Kushwaha 2013-06-21 20:38 ` [U-Boot] [U-Boot, v2] " Andy Fleming 2013-06-21 20:59 ` Scott Wood 2013-06-21 21:05 ` Fleming Andy-AFLEMING 2013-06-21 21:12 ` Scott Wood 2013-06-24 3:14 ` Prabhakar Kushwaha 2013-06-24 6:17 ` Prabhakar Kushwaha 2013-06-24 17:41 ` Scott Wood 2013-06-25 4:37 ` Prabhakar Kushwaha
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox