From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/mpc85xx:Disable Debug TLB entry for non-minimal SPL
Date: Fri, 28 Jun 2013 11:19:25 -0500 [thread overview]
Message-ID: <1372436365.8183.67@snotra> (raw)
In-Reply-To: <51CD51E7.5090306@freescale.com> (from prabhakar@freescale.com on Fri Jun 28 04:05:43 2013)
On 06/28/2013 04:05:43 AM, Prabhakar Kushwaha wrote:
> On 06/27/2013 12:36 AM, Scott Wood wrote:
>> On 06/25/2013 11:09:04 PM, Prabhakar Kushwaha wrote:
>>> then it should be like this. slightly complex.
>>> #if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) &&
>>> !(defined(CONFIG_NAND_SPL) || \
>>> (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_INIT_MINIMAL)))
>>>
>>> or
>>> #if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) && (CONFIG_SYS_RAMBOOT)
>>> || \
>>> (defined(CONFIG_SPL_BUILD) &&
>>> !defined(CONFIG_SPL_INIT_MINIMAL)))
>>
>> The former:
>>
>> http://lists.denx.de/pipermail/u-boot/2013-June/157201.html
>>
> The defines mentioned at this link and earlier written by me will not
> work as they are not taking care of SD boot and NOR boot scenario.
How so?
> Below define will take care of all possible combination
> - NOR , SD, SPI boot
> - NAND_SPL
> - SPL with SPL_INIT_MINIMAL
> - SPL without SPL_INIT_MINIMAL
>
> #if defined(CONFIG_SYS_PPC_E500_DEBUG_TLB) &&
> !defined(CONFIG_NAND_SPL) && \
> (!defined(CONFIG_SPL_BUILD) || !defined(CONFIG_SPL_INIT_MINIMAL))
>
> Took lot of time to figure out :)
That's equivalent to what I suggested in the above link. You just
replaced !(x && y) with (!x || !y).
Or relative to your original suggestion above, you replaced !(x || (y
&& z)) with !x && (!y || !z).
They're all logically equivalent[1]. The question is just which one is
most readable/intuitive.
-Scott
[1] http://en.wikipedia.org/wiki/De_Morgan%27s_laws
next prev parent reply other threads:[~2013-06-28 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 5:03 [U-Boot] [PATCH] powerpc/mpc85xx:Disable Debug TLB entry for non-minimal SPL Prabhakar Kushwaha
2013-06-25 15:08 ` Scott Wood
2013-06-26 4:09 ` Prabhakar Kushwaha
2013-06-26 19:06 ` Scott Wood
2013-06-28 9:05 ` Prabhakar Kushwaha
2013-06-28 16:19 ` Scott Wood [this message]
2013-07-01 8:56 ` Prabhakar Kushwaha
2013-07-01 17:14 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372436365.8183.67@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox