From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chin Liang See <clsee@altera.com>
Date: Mon, 1 Jul 2013 08:38:58 -0500
Subject: [U-Boot] [PATCH 1/1] socfpga: Adding System Manager driver
 which will configure the pin mux for real hardware Cyclone V
In-Reply-To: <20130701103956.GA26322@amd.pavel.ucw.cz>
References: <0BB3B561D7068A4E89FD8E9ABFB538BEB3B2E44095@PG-ITMSG03.altera.priv.altera.com>
	<CAEM3b1BQWGLNvM+m26-OJv_ikc6LPbakiBQjvc2c7Fc5taUmjg@mail.gmail.com>
	<0BB3B561D7068A4E89FD8E9ABFB538BEB3B2E44332@PG-ITMSG03.altera.priv.altera.com>
	<CAEM3b1Dj6h7Z8uo9mnohp=iM8uG_oDofmt+htLi=EQE8ZJMvog@mail.gmail.com>
	<20130628114023.GD22234@amd.pavel.ucw.cz>
	<1372435819.3106.9.camel@drezykow-VirtualBox.altera.com>
	<20130701103956.GA26322@amd.pavel.ucw.cz>
Message-ID: <1372685938.12363.0.camel@drezykow-VirtualBox.altera.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Pavel,

On Mon, 2013-07-01 at 12:39 +0200, ZY - pavel wrote:
> Hi!
> 
> > > > --- /dev/null
> > > > +++ b/board/altera/socfpga_cyclone5/pinmux_config.c
> > > > @@ -0,0 +1,213 @@
> > > > +
> > > > +#include "pinmux_config.h"
> > > > +
> > > > +/* pin mux configuration data */
> > > > +unsigned long sys_mgr_init_table[CONFIG_HPS_PINMUX_NUM] = {
> > > > +       0, /* EMACIO0 - Unused */
> > > > +       2, /* EMACIO1 - USB */
> > > > +       2, /* EMACIO2 - USB */
> > > > +       2, /* EMACIO3 - USB */
> > > 
> > > Is this table auto-generated somehow?
> > > 
> > > If so, comment about that would be nice.
> > > 
> > > If not, perhaps we could put more than one entry on line, to make it
> > > shorter?
> > 
> > Yup, its auto generated by tools.
> > I will put comment to note this.
> 
> Thanks!
> 
> You can add Reviewed-by: Pavel Machek <pavel@denx.de> on the next
> version.
> 

Thanks

> In future, would it make sense to separate auto-generated and manual
> parts? It might be good to have something like pinmux_config.i file
> with just inner part of the table...
> 

Sure, I will split them into 2 patches on next version

Chin Liang

> 									Pavel