public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/3] tools/proftool: remove REG_NOERROR
Date: Tue,  2 Jul 2013 08:37:36 +0200	[thread overview]
Message-ID: <1372747057-85539-3-git-send-email-andreas.devel@googlemail.com> (raw)
In-Reply-To: <1372747057-85539-1-git-send-email-andreas.devel@googlemail.com>

Remove non portable usage of REG_NOERROR.
BSD (like OS X) variants of regex.h do not declare REG_NOERROR, even GNU
regex(3) do mention REG_NOERROR, just remove it.

Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
---
Changes in v2:
 - remove REG_NOERROR instead of defining it conditionally (as Jeroen
   suggested)

 tools/proftool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/proftool.c b/tools/proftool.c
index a48ed28..aa05e77 100644
--- a/tools/proftool.c
+++ b/tools/proftool.c
@@ -333,7 +333,7 @@ static void check_trace_config_line(struct trace_configline_info *item)
 		if (err == REG_NOMATCH)
 			continue;
 
-		if (err != REG_NOERROR) {
+		if (err) {
 			regex_report_error(&item->regex, err, "match",
 					   item->name);
 			break;
-- 
1.8.3.1

  parent reply	other threads:[~2013-07-02  6:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02  6:37 [U-Boot] [PATCH v2 0/3] Adopt u-boot build to OS X Andreas Bießmann
2013-07-02  6:37 ` [U-Boot] [PATCH v2 1/3] lib/rsa/rsa-sig.c: compile on " Andreas Bießmann
2013-07-02  6:37 ` Andreas Bießmann [this message]
2013-07-02 18:19   ` [U-Boot] [PATCH v2 2/3] tools/proftool: remove REG_NOERROR Jeroen Hofstee
2013-07-03 14:24   ` Simon Glass
2013-07-02  6:37 ` [U-Boot] [PATCH v2 3/3] Makefile: fix readelf usage Andreas Bießmann
2013-07-03 19:34 ` [U-Boot] [PATCH v2 0/3] Adopt u-boot build to OS X Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372747057-85539-3-git-send-email-andreas.devel@googlemail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox