From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] am335x_evm: Make NAND support modular
Date: Wed, 17 Jul 2013 16:05:37 -0500 [thread overview]
Message-ID: <1374095137.8183.366@snotra> (raw)
In-Reply-To: <1373396410-23518-2-git-send-email-justin.waters@timesys.com> (from justin.waters@timesys.com on Tue Jul 9 14:00:06 2013)
On 07/09/2013 02:00:06 PM, Justin Waters wrote:
> Give the user the ability to disable NAND support by defining
> CONFIG_NO_NAND. This will allow custom hardware to easily support
> this configuration.
>
> Signed-off-by: Justin Waters <justin.waters@timesys.com>
> ---
> include/configs/am335x_evm.h | 55
> ++++++++++++++++++++++++++++--------------
> 1 file changed, 37 insertions(+), 18 deletions(-)
>
> diff --git a/include/configs/am335x_evm.h
> b/include/configs/am335x_evm.h
> index c5a6d4b..7bcfe2e 100644
> --- a/include/configs/am335x_evm.h
> +++ b/include/configs/am335x_evm.h
> @@ -42,12 +42,39 @@
>
> #define CONFIG_SYS_CACHELINE_SIZE 64
>
> +#ifdef CONFIG_NO_NAND
> +#undef CONFIG_NAND
> +#else
> +#define CONFIG_NAND
> +#endif
Wouldn't it be cleaner to move CONFIG_NAND into boards.cfg, so if you
want NAND to be absent, you just add a similar target that doesn't set
it?
Especially if this is for custom hardware, which ought to get its own
board.cfg line.
-Scott
next prev parent reply other threads:[~2013-07-17 21:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 19:00 [U-Boot] [PATCH 0/5] Enhance support for BeagleBone Black Justin Waters
2013-07-09 19:00 ` [U-Boot] [PATCH 1/5] am335x_evm: Make NAND support modular Justin Waters
2013-07-09 19:44 ` Tom Rini
2013-07-09 19:48 ` Justin Waters
2013-07-17 21:05 ` Scott Wood [this message]
2013-07-17 21:08 ` Scott Wood
2013-07-09 19:00 ` [U-Boot] [PATCH 2/5] am335x_evm: Add am335x_boneblack variant Justin Waters
2013-07-09 19:00 ` [U-Boot] [PATCH 3/5] am335x_evm: Add command line editing Justin Waters
2013-07-09 19:00 ` [U-Boot] [PATCH 4/5] am335x_evm: Rework bootcmd to handle two MMC devs Justin Waters
2013-07-09 19:00 ` [U-Boot] [PATCH 5/5] Add additional MLO images to .gitignore Justin Waters
2013-07-09 19:47 ` [U-Boot] [PATCH 0/5] Enhance support for BeagleBone Black Tom Rini
2013-07-09 20:18 ` Justin Waters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374095137.8183.366@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox