From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 17 Jul 2013 16:05:37 -0500 Subject: [U-Boot] [PATCH 1/5] am335x_evm: Make NAND support modular In-Reply-To: <1373396410-23518-2-git-send-email-justin.waters@timesys.com> (from justin.waters@timesys.com on Tue Jul 9 14:00:06 2013) References: <1373396410-23518-1-git-send-email-justin.waters@timesys.com> <1373396410-23518-2-git-send-email-justin.waters@timesys.com> Message-ID: <1374095137.8183.366@snotra> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/09/2013 02:00:06 PM, Justin Waters wrote: > Give the user the ability to disable NAND support by defining > CONFIG_NO_NAND. This will allow custom hardware to easily support > this configuration. > > Signed-off-by: Justin Waters > --- > include/configs/am335x_evm.h | 55 > ++++++++++++++++++++++++++++-------------- > 1 file changed, 37 insertions(+), 18 deletions(-) > > diff --git a/include/configs/am335x_evm.h > b/include/configs/am335x_evm.h > index c5a6d4b..7bcfe2e 100644 > --- a/include/configs/am335x_evm.h > +++ b/include/configs/am335x_evm.h > @@ -42,12 +42,39 @@ > > #define CONFIG_SYS_CACHELINE_SIZE 64 > > +#ifdef CONFIG_NO_NAND > +#undef CONFIG_NAND > +#else > +#define CONFIG_NAND > +#endif Wouldn't it be cleaner to move CONFIG_NAND into boards.cfg, so if you want NAND to be absent, you just add a similar target that doesn't set it? Especially if this is for custom hardware, which ought to get its own board.cfg line. -Scott