From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mischa Jonker Date: Fri, 26 Jul 2013 16:18:41 +0200 Subject: [U-Boot] [PATCH 2/2] Add parentheses to ALLOC_ALIGN_BUFFER macro's In-Reply-To: <1374848321-15002-1-git-send-email-mjonker@synopsys.com> References: <1374848321-15002-1-git-send-email-mjonker@synopsys.com> Message-ID: <1374848321-15002-2-git-send-email-mjonker@synopsys.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Without those it's very easy to make mistakes when for instance the 'size' field is more than just a constant. Signed-off-by: Mischa Jonker Cc: Alexey Brodkin Cc: Marek Vasut Cc: Anton Staaf Cc: Tom Rini Cc: Wolfgang Denk --- include/common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/common.h b/include/common.h index 8addf43..cc7454a 100644 --- a/include/common.h +++ b/include/common.h @@ -1015,10 +1015,10 @@ static inline phys_addr_t map_to_sysmem(void *ptr) * of a function scoped static buffer. It can not be used to create a cache * line aligned global buffer. */ -#define PAD_COUNT(s, pad) ((s - 1) / pad + 1) +#define PAD_COUNT(s, pad) (((s) - 1) / (pad) + 1) #define PAD_SIZE(s, pad) (PAD_COUNT(s, pad) * pad) #define ALLOC_ALIGN_BUFFER_PAD(type, name, size, align, pad) \ - char __##name[ROUND(PAD_SIZE(size * sizeof(type), pad), align) \ + char __##name[ROUND(PAD_SIZE((size) * sizeof(type), pad), align) \ + (align - 1)]; \ \ type *name = (type *) ALIGN((uintptr_t)__##name, align) -- 1.7.9.5