From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, resend, v3, 5/5] ARM: at91: atmel_nand: add code to check the ONFI parameter ECC requirement
Date: Thu, 22 Aug 2013 17:01:03 +0200 [thread overview]
Message-ID: <1377183663-4111-1-git-send-email-andreas.devel@googlemail.com> (raw)
In-Reply-To: <1372923383-25102-1-git-send-email-josh.wu@atmel.com> from Josh Wu on Thu, 4 Jul 2013 15:36:23 +0800
Dear Josh Wu,
Josh Wu <Josh.wu@atmel.com> writes:
>1. if CONFIG_SYS_NAND_ONFI_DETECTION is defined, driver will check NAND flash's
> ecc minimum requirement in ONFI parameter.
>
> a) if CONFIG_PMECC_CAP, CONFIG_PMECC_SECTOR_SIZE are defined. then use it.
> Driver will display a WARNING if the values are different from ONFI
> parameters.
>
> b) if CONFIG_PMECC_CAP, CONFIG_PMECC_SECTOR_SIZE are not defined, then use
> the value from ONFI parameters.
> * If ONFI ECC parameters are in ONFI extended parameter page, since we
> are not support it, so assume the minimum ecc requirement is 2 bits
> in 512 bytes.
> * For non-ONFI support nand flash, also assume the minimum ecc
> requirement is 2 bits in 512 bytes.
>
>2. if CONFIG_SYS_NAND_ONFI_DETECTION is not defined, just use CONFIG_PMECC_CAP
> and CONFIG_PMECC_SECTOR_SIZE.
>
>Signed-off-by: Josh Wu <josh.wu@atmel.com>
>Acked-by: Scott Wood <scottwood@freescale.com>
>---
>resend:
> use braces around muti-line if/loop body.
>
>v2 --> v3:
> use dev_err/info(host->dev) instead of dev_err/info(NULL).
> use MTDDEBUG() instead of pr_debug().
>
>v1 --> v2:
> use dev_err/info to replace printk.
> fix typo mistake, that should use <= instead of use <.
>
> drivers/mtd/nand/atmel_nand.c | 130 ++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 128 insertions(+), 2 deletions(-)
applied to u-boot-atmel/master, thanks!
Best regards,
Andreas Bie?mann
next prev parent reply other threads:[~2013-08-22 15:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 3:11 [U-Boot] [PATCH v3 0/5] ARM: at91: atmel_nand: check ONFI ecc minimum requirement Josh Wu
2013-07-03 3:11 ` [U-Boot] [PATCH v3 1/5] ARM: at91: atmel_nand: pmecc driver will select the galois table by sector size Josh Wu
2013-08-22 15:00 ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2013-07-03 3:11 ` [U-Boot] [PATCH v3 2/5] ARM: at91: sama5d3: remove unused definition about PMECC alpha table offset Josh Wu
2013-08-22 15:00 ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2013-07-03 3:11 ` [U-Boot] [PATCH v3 3/5] linux/compat.h: move dev_err, dev_info and dev_dbg from usb driver to compat.h Josh Wu
2013-08-22 15:00 ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2013-07-03 3:11 ` [U-Boot] [PATCH v3 4/5] mtd: atmel_nand: alloc memory instead of use static array for pmecc data Josh Wu
2013-08-22 15:00 ` [U-Boot] [U-Boot, v3, " Andreas Bießmann
2013-07-03 3:11 ` [U-Boot] [PATCH v3 5/5] ARM: at91: atmel_nand: add code to check the ONFI parameter ECC requirement Josh Wu
2013-07-03 22:12 ` Scott Wood
2013-07-04 7:28 ` Josh Wu
2013-07-04 7:36 ` [U-Boot] [resend][PATCH " Josh Wu
2013-08-22 15:01 ` Andreas Bießmann [this message]
2013-08-09 10:00 ` [U-Boot] [PATCH v3 0/5] ARM: at91: atmel_nand: check ONFI ecc minimum requirement Josh Wu
2013-08-10 0:13 ` Scott Wood
2013-08-22 10:07 ` Josh Wu
2013-08-22 10:29 ` Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377183663-4111-1-git-send-email-andreas.devel@googlemail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox