public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rob Herring <robherring2@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 6/8] ahci: handle COMINIT received during spin-up
Date: Sat, 24 Aug 2013 10:10:52 -0500	[thread overview]
Message-ID: <1377357054-27408-6-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1377357054-27408-1-git-send-email-robherring2@gmail.com>

From: Rob Herring <rob.herring@calxeda.com>

Some Intel SSDs can send a COMINIT after the initial COMRESET. This causes
the link to go down and we need to re-initialize the link.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
v2: Use define values for PORT_SCR

 drivers/block/ahci.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c
index 5e7d01b..a7044f2 100644
--- a/drivers/block/ahci.c
+++ b/drivers/block/ahci.c
@@ -243,8 +243,20 @@ static int ahci_host_init(struct ahci_probe_ent *probe_ent)
 			if (!(tmp & (ATA_STAT_BUSY | ATA_STAT_DRQ)))
 				break;
 			udelay(1000);
+			tmp = readl(port_mmio + PORT_SCR_STAT);
+			tmp &= PORT_SCR_STAT_DET_MASK;
+			if (tmp == PORT_SCR_STAT_DET_PHYRDY)
+				break;
 			j++;
 		}
+
+		tmp = readl(port_mmio + PORT_SCR_STAT) & PORT_SCR_STAT_DET_MASK;
+		if (tmp == PORT_SCR_STAT_DET_COMINIT) {
+			debug("SATA link %d down (COMINIT received), retrying...\n", i);
+			i--;
+			continue;
+		}
+
 		printf("Target spinup took %d ms.\n", j);
 		if (j == WAIT_MS_SPINUP)
 			debug("timeout.\n");
-- 
1.8.1.2

  parent reply	other threads:[~2013-08-24 15:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-24 15:10 [U-Boot] [PATCH v2 1/8] ahci: use ports implemented map instead of num_ports Rob Herring
2013-08-24 15:10 ` [U-Boot] [PATCH v2 2/8] ahci: fix unaligned access Rob Herring
2013-08-24 15:10 ` [U-Boot] [PATCH v2 3/8] ahci: fix memory leak in ata_scsiop_inquiry Rob Herring
2013-08-24 15:10 ` [U-Boot] [PATCH v2 4/8] ahci: add defines for PORT_SCR_STAT register bits Rob Herring
2013-08-24 15:10 ` [U-Boot] [PATCH v2 5/8] ahci: move link bring-up handling to separate function Rob Herring
2013-08-24 15:10 ` Rob Herring [this message]
2013-08-24 15:10 ` [U-Boot] [PATCH v2 7/8] ahci: increase spin-up timeout to 20 sec Rob Herring
2013-08-24 15:10 ` [U-Boot] [PATCH v2 8/8] ahci: convert to use libata functions and definitions Rob Herring
2013-09-06 21:24 ` [U-Boot] [U-Boot, v2, 1/8] ahci: use ports implemented map instead of num_ports Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377357054-27408-6-git-send-email-robherring2@gmail.com \
    --to=robherring2@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox