From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ajay Bhargav <ajay.bhargav@einfochips.com>
Date: Mon, 29 Aug 2011 11:09:18 +0530 (IST)
Subject: [U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller
 driver for Armada100
In-Reply-To: <201108290130.14251.vapier@gentoo.org>
Message-ID: <1377932120.14674.1314596358776.JavaMail.root@ahm.einfochips.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


----- "Mike Frysinger" <vapier@gentoo.org> wrote:

> On Monday, August 29, 2011 01:10:49 Ajay Bhargav wrote:
> > ----- "Mike Frysinger" <vapier@gentoo.org> wrote:
> > > On Friday, August 26, 2011 02:36:51 Ajay Bhargav wrote:
> > > > +        darmdfec = malloc(sizeof(struct armdfec_device));
> > > > +        if (!darmdfec)
> > > > +                goto error;
> > > 
> > > if this first one fails, we jump to:
> > > > +error:
> > > > +        free(darmdfec->p_aligned_txbuf);
> > > > +        free(darmdfec->p_rxbuf);
> > > > +        free(darmdfec->p_rxdesc);
> > > > +        free(darmdfec->htpr);
> > > 
> > > looks like 4 NULL pointer derefs.  so you'll need one specific
> path
> > > for the first malloc(), but the rest are fine.
> > 
> > so you mean like this...
> > 
> > if(!darmdfec)
> >         goto error;
> > ...
> > error1:
> >         free(darmdfec->p_aligned_txbuf);
> >         free(darmdfec->p_rxbuf);
> >         free(darmdfec->p_rxdesc);
> >         free(darmdfec->htpr);
> > error:
> >         free(darmdfec);
> >         return -1;
> 
> that's one way of fixing it
> -mike
Any other better way?

--Ajay