From: Ian Campbell <ian.campbell@citrix.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pxe: fix handling of absolute paths
Date: Tue, 22 Oct 2013 11:34:51 +0100 [thread overview]
Message-ID: <1382438091.1657.87.camel@hastur.hellion.org.uk> (raw)
In-Reply-To: <1382119482-26224-1-git-send-email-robherring2@gmail.com>
On Fri, 2013-10-18 at 13:04 -0500, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> pxelinux and syslinux differ in their handling of absolute paths in menu
> files. A pxelinux path is aways prepended with the bootfile path while
> syslinux allows for absolute paths. u-boot was always treating a leading
> / as an absolute path breaking some pxelinux setups. Fix this by adding
> a flag to distinguish pxelinux vs. syslinux behavior.
>
> Reported-by: Ian Campbell <Ian.Campbell@citrix.com>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
You could also have Tested- or Acked-by from me if desired.
I also took a gander at the syslinux code and found that
core/fs/pxe/pxe.c:get_prefix() sets the initial cwd to the prefix. The
lookups are done relative to this unless the path is a URL (roughly
means it contains "::", see code/comments around the use of
PXE_RELATIVE)). In particular a leading "/" isn't specially treated as
far as I can see...
Ian.
next prev parent reply other threads:[~2013-10-22 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 18:04 [U-Boot] [PATCH] pxe: fix handling of absolute paths Rob Herring
2013-10-22 10:34 ` Ian Campbell [this message]
2013-11-04 21:31 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382438091.1657.87.camel@hastur.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox