From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/esdhc: Map register for eSDHC host controller 3.0
Date: Tue, 29 Oct 2013 12:54:00 -0500 [thread overview]
Message-ID: <1383069240.3410.90.camel@snotra.buserror.net> (raw)
In-Reply-To: <1383018539-22799-1-git-send-email-Haijun.Zhang@freescale.com>
On Tue, 2013-10-29 at 11:48 +0800, Haijun Zhang wrote:
> eSDHC host controller has new register to support SD Spec 3.0.
> And the according host controller version was Freescale eSDHC
> Version 3.0. Add some new register and it simple description.
>
> Signed-off-by: Haijun Zhang <haijun.zhang@freescale.com>
> ---
> drivers/mmc/fsl_esdhc.c | 62 +++++++++++++++++++++++++++++--------------------
> 1 file changed, 37 insertions(+), 25 deletions(-)
By adding a register in the same patch as you add descriptions, you make
it hard to see what register you added.
-Scott
next prev parent reply other threads:[~2013-10-29 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 3:48 [U-Boot] [PATCH] powerpc/esdhc: Map register for eSDHC host controller 3.0 Haijun Zhang
2013-10-29 17:54 ` Scott Wood [this message]
2013-10-30 2:04 ` Zhang Haijun
-- strict thread matches above, loose matches on Subject: below --
2013-10-29 3:51 Haijun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383069240.3410.90.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox