From: Tom Warren <TWarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tegra: Indicate that binman makes all three output files
Date: Thu, 26 Jul 2018 19:45:23 +0000 [thread overview]
Message-ID: <1383760714e64a3b96c9210d0b43effd@HQMAIL101.nvidia.com> (raw)
In-Reply-To: <20180726193941.GB7590@bill-the-cat>
I don't usually weigh in on makefile issues, but if Stephen says it's needed, let's get it in.
-----Original Message-----
From: Tom Rini <trini@konsulko.com>
Sent: Thursday, July 26, 2018 12:40 PM
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Simon Glass <sjg@chromium.org>; U-Boot Mailing List <u-boot@lists.denx.de>; Stephen Warren <swarren@nvidia.com>; Tom Warren <TWarren@nvidia.com>
Subject: Re: [PATCH] tegra: Indicate that binman makes all three output files
On Thu, Jul 26, 2018 at 01:37:31PM -0600, Stephen Warren wrote:
> On 07/23/2018 09:27 AM, Stephen Warren wrote:
> >On 07/20/2018 07:49 PM, Simon Glass wrote:
> >>Use GNU make pattern rules to indicate that a single run of binman
> >>produces all three Tegra output files. The avoids make running
> >>binman three times (perhaps in parallel) and those instances
> >>inteferring with each other.
> >>
> >>See http://patchwork.ozlabs.org/patch/944611/ for the bug report.
> >
> >Tested-by: Stephen Warren <swarren@nvidia.com>
> >
> >(This make feature is very odd; specifying n targets without a %
> >means they're separate rules, but specifying n targets with a % means
> >it's a single rule that generates n targets. Nice inconsistency on
> >make's part!)
>
> Any chance we can apply this ASAP to the main u-boot.git master branch?
> Pretty much all my Jenkins builds are failing some random subset of
> boards because of this issue. Thanks.
If Tom W is fine, I'm happy to pick it up directly.
--
Tom
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
next prev parent reply other threads:[~2018-07-26 19:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-21 1:49 [U-Boot] [PATCH] tegra: Indicate that binman makes all three output files Simon Glass
2018-07-23 15:27 ` Stephen Warren
2018-07-26 19:37 ` Stephen Warren
2018-07-26 19:39 ` Tom Rini
2018-07-26 19:45 ` Tom Warren [this message]
2018-07-26 19:38 ` Simon Glass
2018-07-26 19:55 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383760714e64a3b96c9210d0b43effd@HQMAIL101.nvidia.com \
--to=twarren@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox