[U-Boot] [PATCH 4/4] udoo: fix watchdog setting

Stefano Babic
2013-11-07T08:19:08Z

Hi Giuseppe,

On 06/11/2013 21:44, Giuseppe Pagano wrote:
> To have watchdog quiet during kernel boot it is necessary to
> change gpio wdt trigger direction.
>

Sorry, this is not a good explanation. You force a GPIO to drop a
feture, instead of disabling the feature itself. And maybe some other
people want to have this feature enabled.

Which is the timeout for the watchdog ? Why is it hitting too soon ?

Fix should be not done simply removing the effect, but checking the cause.

>
> Signed-off-by: Giuseppe Pagano <giuseppe.pagano@seco.com>
> Cc: sbabic at denx.de
>
> ---
>
> diff -uNr a/board/udoo/udoo.c b/board/udoo/udoo.c
> --- a/board/udoo/udoo.c 2013-11-06 18:47:26.000000000 +0100
> +++ b/board/udoo/udoo.c 2013-11-06 18:54:46.000000000 +0100
> @@ -168,6 +168,7 @@
> imx_iomux_v3_setup_multiple_pads(wdog_pads,
> ARRAY_SIZE(wdog_pads));
> gpio_direction_output(WDT_TRG, 0);
> gpio_direction_output(WDT_EN, 1);
> + gpio_direction_input(WDT_TRG);

I do not think this a right way to disable a watchdog.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================