public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Giuseppe Pagano <giuseppe.pagano@seco.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] udoo: Adjust default boot envirnment
Date: Thu, 07 Nov 2013 12:59:42 +0100	[thread overview]
Message-ID: <1383825582.3371.76.camel@localhost> (raw)
In-Reply-To: <527B506D.7070604@denx.de>

Hi Stefano,

On Thu, 2013-11-07 at 09:33 +0100, Stefano Babic wrote:
> Hi Giuseppe,
> 
> On 06/11/2013 21:44, Giuseppe Pagano wrote:
> > Change u-boot default environment for uDoo board to:
> >   - mount /dev/mmcblk0p1 partition
> >   - activate hdmi monitor by default (instead of nothing)
> > 
> > Signed-off-by: Giuseppe Pagano <giuseppe.pagano@seco.com>
> > Cc: sbabic at denx.de
....
> 
> I have already explained my doubts regarding the abuse of
> EXTRA_ENV_SETTINGS. The setup that should be minimal and general for
> most of uses is then customized for a specific scope, that conflict with
> other goals. 

Ok I will leave unchanged default environment.


> > @@ -189,7 +190,7 @@
> >  /* Miscellaneous configurable options */
> >  #define CONFIG_SYS_LONGHELP
> >  #define CONFIG_SYS_HUSH_PARSER
> > -#define CONFIG_SYS_PROMPT             "=> "
> > +#define CONFIG_SYS_PROMPT		"uDoo board >"
> >  #define CONFIG_AUTO_COMPLETE
> >  #define CONFIG_SYS_CBSIZE              256
> 
> We had already some discussion on the mailing list about the meaning and
> the usefulness of the U-Boot prompt. I will apply a patch for all
> Freescale boards that remove a custom prompt, letting the default. Which
> is the improvement to have a custom prompt ?

And also I will leave unchanged u-boot prompt. 
I think I will support Simon idea, I think it is useful to recognize
uboot console prompt if you have more than one serial console connected
to your host. 


> 
> Maybe you are the second one asking for the feature:
> 
> http://u-boot.10912.n7.nabble.com/Changing-CONFIG-SYS-PROMPT-on-the-fly-td166105.html
> 
> As suggested by Simon (take a look at the whole thread), it is then
> better to set the prompt from an environment variable. Feel free to
> submit a patch for it.
> 
> Best regards,
> Stefano Babic
> 

Best regards,
Giuseppe Pagano

      reply	other threads:[~2013-11-07 11:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06 20:44 [U-Boot] [PATCH 3/4] udoo: Adjust default boot envirnment Giuseppe Pagano
2013-11-07  8:33 ` Stefano Babic
2013-11-07 11:59   ` Giuseppe Pagano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383825582.3371.76.camel@localhost \
    --to=giuseppe.pagano@seco.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox