From mboxrd@z Thu Jan  1 00:00:00 1970
From: Giuseppe Pagano <giuseppe.pagano@seco.com>
Date: Thu, 07 Nov 2013 13:41:45 +0100
Subject: [U-Boot] [PATCH 2/4] udoo: Add SATA disk support.
In-Reply-To: <527B5206.4080001@denx.de>
References: <1383770243.3741.22.camel@localhost> <527B5206.4080001@denx.de>
Message-ID: <1383828105.3371.94.camel@localhost>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, 2013-11-07 at 09:40 +0100, Stefano Babic wrote:
> Hi Giuseppe,
> 
> On 06/11/2013 21:37, Giuseppe Pagano wrote:
> > Add Sata support on uDoo Board.
> > 
> > Signed-off-by: Giuseppe Pagano <giuseppe.pagano@seco.com>
> > Cc: sbabic at denx.de
> > 
> > ---
....
> > +#ifdef CONFIG_CMD_SATA
> > +int setup_sata(void)
> > +{
> > +	struct iomuxc_base_regs *const iomuxc_regs
> > +		= (struct iomuxc_base_regs *)IOMUXC_BASE_ADDR;
> > +
> > +	int ret = enable_sata_clock();
> > +	if (ret)
> > +		return ret;
> > +
> > +	clrsetbits_le32(&iomuxc_regs->gpr[13],
> > +			IOMUXC_GPR13_SATA_MASK,
> > +			IOMUXC_GPR13_SATA_PHY_8_RXEQ_3P0DB
> > +			|IOMUXC_GPR13_SATA_PHY_7_SATA2M
> > +			|IOMUXC_GPR13_SATA_SPEED_3G
> > +			|(3<<IOMUXC_GPR13_SATA_PHY_6_SHIFT)
> > +			|IOMUXC_GPR13_SATA_SATA_PHY_5_SS_DISABLED
> > +			|IOMUXC_GPR13_SATA_SATA_PHY_4_ATTEN_9_16
> > +			|IOMUXC_GPR13_SATA_PHY_3_TXBOOST_0P00_DB
> > +			|IOMUXC_GPR13_SATA_PHY_2_TX_1P104V
> > +			|IOMUXC_GPR13_SATA_PHY_1_SLOW);
> > +
> > +	return 0;
> > +}
> > +#endif
> 
> Do not copy code ! If you want to reuse functions from nitrogen, please
> factorize the function and put it into imx-common, thanks.

Ok, I'll do. 
I'm going to produce a new udoo patch with git send-patch and I'll
submit as v2 of this one. 

> Best regards,
> Stefano Babic

Best regards,
Giuseppe Pagano