From mboxrd@z Thu Jan  1 00:00:00 1970
From: Giuseppe Pagano <giuseppe.pagano@seco.com>
Date: Fri, 15 Nov 2013 12:48:35 +0100
Subject: [U-Boot] [PATCH v1 2/4] udoo: Add ethernet support (FEC +
 Micrel KSZ9031).
In-Reply-To: <528340B6.9090500@denx.de>
References: <1384189918-7755-1-git-send-email-giuseppe.pagano@seco.com>
	<1384189918-7755-2-git-send-email-giuseppe.pagano@seco.com>
	<528340B6.9090500@denx.de>
Message-ID: <1384516115.9742.49.camel@localhost>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefano,

On Wed, 2013-11-13 at 10:04 +0100, Stefano Babic wrote:
> Hi Giuseppe,
> 
> On 11/11/2013 18:11, Giuseppe Pagano wrote:
> > Add Ethernet and networking support on uDoo board (FEC + phy Micrel KSZ9031).
> > 
> > Signed-off-by: Giuseppe Pagano <giuseppe.pagano@seco.com>
> > CC: Stefano Babic <sbabic@denx.de>
> > CC: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> 
> ok - remember to increment the version number of the patchset for next
> time (this is really V2 instead of V1).

Ok, I'm going to prepare next patch. Sorry for the error, for this time
I think it would be better to use V2 in next submit to reduce confusion.

> > +int mx6_rgmii_rework(struct phy_device *phydev)
> > +{
> > +	/*
> > +	 * Bug: Apparently uDoo does not works with Gigabit switches...
> > +	 * Limiting speed to 10/100Mbps, and setting master mode, seems to
> > +	 * be the only way to have a successfull PHY auto negotiation.
> > +	 * How to fix: Understand why Linux kernel do not have this issue.
> > +	 */
> 
> Fine. This is ok, but could you also add to the commit message that
> Ethernet is currently limited to 10/100Mbps ?

Ok, I will do.

> 
> Best regards,
> Stefano Babic

Best Regards
Giuseppe Pagano