public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v10 2/4] mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform
Date: Wed, 20 Nov 2013 18:14:54 -0600	[thread overview]
Message-ID: <1384992894.1403.454.camel@snotra.buserror.net> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EA47CC2@DBDE04.ent.ti.com>

On Wed, 2013-11-20 at 04:09 +0000, Gupta, Pekon wrote:
> > From: Scott Wood [mailto:scottwood at freescale.com]
> > On Mon, 2013-11-18 at 19:03 +0530, Pekon Gupta wrote:
> > > @@ -763,77 +903,47 @@ static void __maybe_unused
> > omap_free_bch(struct mtd_info *mtd)
> > >   * @eccstrength		- the number of bits that could be corrected
> > >   *			  (1 - hamming, 4 - BCH4, 8 - BCH8, 16 - BCH16)
> > >   */
> > > -void omap_nand_switch_ecc(uint32_t hardware, uint32_t eccstrength)
> > > +int __maybe_unused omap_nand_switch_ecc(uint32_t hardware,
> > uint32_t eccstrength)
> > >  {
> > >  	struct nand_chip *nand;
> > >  	struct mtd_info *mtd;
> > > +	struct nand_bch_priv *bch;
> > > +	int err = 0;
> > 
> > bch gives unused warning
> > 
> Sorry, I would have missed it.. I would clean this.

If that's the only issue, I can resolve it when applying.

> > I tried to see if the warning goes away later, but patch 3/4 doesn't
> > apply cleanly.  What tree is this patchset against?
> > 
> These patches should apply cleanly on 
> 	git://git.denx.de/u-boot.git  master
> Do you have any other tree on which you want me to re-base ?

Never mind -- I had some old reject files that made me think the
conflict was in files that I hadn't touched yet (such as omap_gpmc.c),
but the only conflict was in include/config/tricorder.h which I had
touched in an earlier patch.

-Scott

  reply	other threads:[~2013-11-21  0:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 13:32 [U-Boot] [PATCH v10 0/4] mtd: nand: omap: optimize and clean-up of OMAP NAND driver Pekon Gupta
2013-11-18 13:32 ` [U-Boot] [PATCH v10 1/4] mtd: nand: omap: make am33xx/elm.c as common driver for all OMAPx and AMxxxx platforms Pekon Gupta
2013-11-18 13:33 ` [U-Boot] [PATCH v10 2/4] mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform Pekon Gupta
2013-11-20  0:13   ` Scott Wood
2013-11-20  4:09     ` Gupta, Pekon
2013-11-21  0:14       ` Scott Wood [this message]
2013-11-21  5:17         ` Gupta, Pekon
2013-11-18 13:33 ` [U-Boot] [PATCH v10 3/4] mtd: nand: omap: add CONFIG_NAND_OMAP_ECCSCHEME for selection of ecc-scheme Pekon Gupta
2013-11-18 13:33 ` [U-Boot] [PATCH v10 4/4] am335x: fix GPMC config for NAND and NOR SPL boot Pekon Gupta
2013-11-19 12:14 ` [U-Boot] [PATCH v10 0/4] mtd: nand: omap: optimize and clean-up of OMAP NAND driver Ezequiel Garcia
2013-11-19 20:44 ` Meier, Roger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384992894.1403.454.camel@snotra.buserror.net \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox