From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] net: fec_mxc: Fix setting of RCR for xMII
Date: Sat, 21 Jul 2012 15:49:16 +0200 (CEST) [thread overview]
Message-ID: <1385480964.368263.1342878556597.JavaMail.root@advansee.com> (raw)
In-Reply-To: <9848F2DB572E5649BA045B288BE08FBEE2A8C0@039-SN2MPN1-021.039d.mgd.msft.net>
Hi Andy,
On Fri, Jul 20, 2012 at 07:35:30AM, Duan Fugang-B38611 wrote:
> The changes is reasonable. Thanks!
>
> Best Regards,
> Andy
The change for MII_MODE is clear.
As to FCE, this can be discussed, and it depends on the hardware support.
Actually, fec_open enables full-duplex in TCR regardless of xcv_type, so a
further change could be to set the FCE bit for full-duplex flow control in
fec_reg_setup regardless of xcv_type, or on the contrary, to make the
full-duplex setting in fec_open depend on xcv_type. In the latter case, RCR[DRT]
could also be set for the half-duplex case.
Best regards,
Beno?t
next parent reply other threads:[~2012-07-21 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9848F2DB572E5649BA045B288BE08FBEE2A8C0@039-SN2MPN1-021.039d.mgd.msft.net>
2012-07-21 13:49 ` Benoît Thébaudeau [this message]
[not found] <9848F2DB572E5649BA045B288BE08FBEE2D9DD@039-SN2MPN1-021.039d.mgd.msft.net>
2012-07-23 17:43 ` [U-Boot] [PATCH 1/2] net: fec_mxc: Fix setting of RCR for xMII Benoît Thébaudeau
2012-07-19 12:12 Benoît Thébaudeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385480964.368263.1342878556597.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox