From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= <benoit.thebaudeau@advansee.com>
Date: Sat, 21 Jul 2012 15:49:16 +0200 (CEST)
Subject: [U-Boot] [PATCH 1/2] net: fec_mxc: Fix setting of RCR for xMII
In-Reply-To: <9848F2DB572E5649BA045B288BE08FBEE2A8C0@039-SN2MPN1-021.039d.mgd.msft.net>
Message-ID: <1385480964.368263.1342878556597.JavaMail.root@advansee.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Andy,

On Fri, Jul 20, 2012 at 07:35:30AM, Duan Fugang-B38611 wrote:
> The changes is reasonable. Thanks!
> 
> Best Regards,
> Andy

The change for MII_MODE is clear.

As to FCE, this can be discussed, and it depends on the hardware support.
Actually, fec_open enables full-duplex in TCR regardless of xcv_type, so a
further change could be to set the FCE bit for full-duplex flow control in
fec_reg_setup regardless of xcv_type, or on the contrary, to make the
full-duplex setting in fec_open depend on xcv_type. In the latter case, RCR[DRT]
could also be set for the half-duplex case.

Best regards,
Beno?t