public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: Remove unused !CONFIG_SPL_BUILD code in board_init_f()
Date: Wed, 27 Nov 2013 12:22:05 -0500	[thread overview]
Message-ID: <1385572925-18592-1-git-send-email-trini@ti.com> (raw)

Some code in board_init_f that dates back to the initial relocation
support had if/else for PRELOADER (which became SPL_BUILD) about setting
the stack pointer.  But, board.c is never built for CONFIG_SPL_BUILD
now, so this really makes no sense.  Drop this section.

Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Tom Rini <trini@ti.com>
---
 arch/arm/lib/board.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
index 34f50b0..3c519a8 100644
--- a/arch/arm/lib/board.c
+++ b/arch/arm/lib/board.c
@@ -377,7 +377,6 @@ void board_init_f(ulong bootflag)
 
 	debug("Reserving %ldk for U-Boot at: %08lx\n", gd->mon_len >> 10, addr);
 
-#ifndef CONFIG_SPL_BUILD
 	/*
 	 * reserve memory for malloc() arena
 	 */
@@ -431,10 +430,6 @@ void board_init_f(ulong bootflag)
 
 	/* 8-byte alignment for ABI compliance */
 	addr_sp &= ~0x07;
-#else
-	addr_sp += 128;	/* leave 32 words for abort-stack   */
-	gd->irq_sp = addr_sp;
-#endif
 	interrupt_init();
 
 	debug("New Stack Pointer is: %08lx\n", addr_sp);
-- 
1.7.9.5

             reply	other threads:[~2013-11-27 17:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 17:22 Tom Rini [this message]
2013-11-28  1:38 ` [U-Boot] [PATCH] arm: Remove unused !CONFIG_SPL_BUILD code in board_init_f() Masahiro Yamada
2013-11-28  1:41   ` Simon Glass
2013-11-28  7:44     ` Masahiro Yamada
2013-11-28  2:21   ` Tom Rini
2014-02-13  8:57 ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385572925-18592-1-git-send-email-trini@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox