public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/6] mx6qarm2: Remove unneeded error message when cpu_eth_init() fails
Date: Sat,  4 Jan 2014 17:36:30 -0200	[thread overview]
Message-ID: <1388864193-5716-3-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1388864193-5716-1-git-send-email-festevam@gmail.com>

From: Fabio Estevam <fabio.estevam@freescale.com>

There is no need to print an error message when cpu_eth_init() fails because
net/eth.c already prints it.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Separate declarations and code by a blank line 

 board/freescale/mx6qarm2/mx6qarm2.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/board/freescale/mx6qarm2/mx6qarm2.c b/board/freescale/mx6qarm2/mx6qarm2.c
index e063407..6c51f3a 100644
--- a/board/freescale/mx6qarm2/mx6qarm2.c
+++ b/board/freescale/mx6qarm2/mx6qarm2.c
@@ -186,13 +186,10 @@ int fecmxc_mii_postcall(int phy)
 int board_eth_init(bd_t *bis)
 {
 	struct eth_device *dev;
-	int ret;
+	int ret = cpu_eth_init(bis);
 
-	ret = cpu_eth_init(bis);
-	if (ret) {
-		printf("FEC MXC: %s:failed\n", __func__);
+	if (ret)
 		return ret;
-	}
 
 	dev = eth_get_dev_by_name("FEC");
 	if (!dev) {
-- 
1.8.1.2

  parent reply	other threads:[~2014-01-04 19:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-04 19:36 [U-Boot] [PATCH v2 1/6] wandboard: Return from cpu_eth_init() directly Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 2/6] titanium: " Fabio Estevam
2014-01-06  6:45   ` Stefan Roese
2014-01-04 19:36 ` Fabio Estevam [this message]
2014-01-04 19:36 ` [U-Boot] [PATCH v2 4/6] mx6qsabreauto: " Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 5/6] mx6sabresd: " Fabio Estevam
2014-01-04 19:36 ` [U-Boot] [PATCH v2 6/6] mx6slevk: " Fabio Estevam
2014-01-13 10:56 ` [U-Boot] [PATCH v2 1/6] wandboard: " Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388864193-5716-3-git-send-email-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox