[U-Boot] [PATCH v4] nand: add Faraday FTNANDC021 NAND controller support

Scott Wood
2013-05-09T00:43:05Z

On 05/07/2013 01:33:11 AM, Kuo-Jung Su wrote:
> From: Kuo-Jung Su <dantesu@faraday-tech.com>
>
> Faraday FTNANDC021 is a integrated NAND flash controller.
> It use a build-in command table to abstract the underlying
> NAND flash control logic.
>
> For example:
>
> Issuing a command 0x10 to FTNANDC021 would result in
> a page write + a read status operation.
>
> Signed-off-by: Kuo-Jung Su <dantesu@faraday-tech.com>
> CC: Scott Wood <scottwood@freescale.com>

Looks mostly OK, just a couple nits:

> diff --git a/README b/README
> index 0d37d56..883182d 100644
> --- a/README
> +++ b/README
> @@ -3879,6 +3879,10 @@ Low Level (hardware related) configuration
> options:
> - drivers/mtd/nand/ndfc.c
> - drivers/mtd/nand/mxc_nand.c
>
> +- CONFIG_SYS_FTNANDC021_TIMING
> + Defined to tell the FTNANDC021 controller that the NAND
> chip is
> + using customized timing parameters.

This makes it sound like a boolean option, but it's actually an array --
would be nice to mention what's actually expected.

> + if (mtd->writesize >= 4096) {

Whitespace

-Scott