From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/4] ahci: wait longer for link.
Date: Fri, 7 Mar 2014 01:20:58 +0000 [thread overview]
Message-ID: <1394155259-21897-3-git-send-email-ijc@hellion.org.uk> (raw)
In-Reply-To: <1394155172.13270.18.camel@hastur.hellion.org.uk>
I have observed timeouts on a cubietruck.
The increase to 40ms is completely arbitrary and Works For Me(tm). I
couldn't find a good reference for how long you are supposed to wait,
although googling around it seems like tens of ms rather than single
digits is more common. I don't think there is any harm in waiting a bit
longer.
Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
---
drivers/block/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c
index d5370fa..90a0719 100644
--- a/drivers/block/ahci.c
+++ b/drivers/block/ahci.c
@@ -41,7 +41,7 @@ u16 *ataid[AHCI_MAX_PORTS];
#define WAIT_MS_SPINUP 20000
#define WAIT_MS_DATAIO 5000
#define WAIT_MS_FLUSH 5000
-#define WAIT_MS_LINKUP 4
+#define WAIT_MS_LINKUP 40
static inline u32 ahci_port_base(u32 base, u32 port)
{
--
1.8.5.3
next prev parent reply other threads:[~2014-03-07 1:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 1:19 [U-Boot] [PATCH v3 0/4] uboot sata support for sunxi platform Ian Campbell
2014-03-07 1:20 ` [U-Boot] [PATCH v3 1/4] ahci-plat: Provide a weak scsi_init hook Ian Campbell
2014-03-10 21:27 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-03-07 1:20 ` [U-Boot] [PATCH v3 2/4] highbank: use " Ian Campbell
2014-03-07 2:43 ` Rob Herring
2014-03-10 21:28 ` [U-Boot] [U-Boot,v3,2/4] " Tom Rini
2014-03-07 1:20 ` Ian Campbell [this message]
2014-03-10 21:28 ` [U-Boot] [U-Boot,v3,3/4] ahci: wait longer for link Tom Rini
2014-03-07 1:20 ` [U-Boot] [PATCH v3 4/4] ahci: provide sunxi SATA driver using AHCI platform framework Ian Campbell
2014-03-07 1:24 ` [U-Boot] [linux-sunxi] [PATCH v3 0/4] uboot sata support for sunxi platform Ian Campbell
2014-03-07 16:44 ` Ezaul Zillmer
2014-03-08 4:16 ` Ian Campbell
2014-03-12 12:43 ` Ezaul Zillmer
2014-03-12 12:56 ` Ian Campbell
2014-03-12 13:17 ` Koen Kooi
2014-03-12 15:04 ` Ian Campbell
2014-03-12 13:53 ` Ezaul Zillmer
2014-03-12 15:57 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394155259-21897-3-git-send-email-ijc@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox