From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/5] arm1136: move cache code from start.S to cache.c
Date: Sun, 9 Mar 2014 17:18:19 +0100 [thread overview]
Message-ID: <1394381903-7007-2-git-send-email-albert.u.boot@aribaud.net> (raw)
In-Reply-To: <1394381903-7007-1-git-send-email-albert.u.boot@aribaud.net>
arch/arm/cpu/arm1136/start.S contain a cache flushing function.
Remove the function and move its code into arch/arm/lib/cache.c.
Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
---
Changes in v2: None
arch/arm/cpu/arm1136/start.S | 10 ----------
arch/arm/lib/cache.c | 13 ++++++++++---
2 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/arch/arm/cpu/arm1136/start.S b/arch/arm/cpu/arm1136/start.S
index 3e2358e..0085754 100644
--- a/arch/arm/cpu/arm1136/start.S
+++ b/arch/arm/cpu/arm1136/start.S
@@ -333,14 +333,4 @@ fiq:
bl do_fiq
#endif
- .align 5
-.global arm1136_cache_flush
-arm1136_cache_flush:
-#if !defined(CONFIG_SYS_ICACHE_OFF)
- mcr p15, 0, r1, c7, c5, 0 @ invalidate I cache
-#endif
-#if !defined(CONFIG_SYS_DCACHE_OFF)
- mcr p15, 0, r1, c7, c14, 0 @ invalidate D cache
-#endif
- mov pc, lr @ back to caller
#endif /* CONFIG_SPL_BUILD */
diff --git a/arch/arm/lib/cache.c b/arch/arm/lib/cache.c
index 6cc136a..4f6b9f0 100644
--- a/arch/arm/lib/cache.c
+++ b/arch/arm/lib/cache.c
@@ -12,16 +12,23 @@
void __flush_cache(unsigned long start, unsigned long size)
{
#if defined(CONFIG_ARM1136)
- void arm1136_cache_flush(void);
- arm1136_cache_flush();
+#if !defined(CONFIG_SYS_ICACHE_OFF)
+ asm("mcr p15, 0, r1, c7, c5, 0"); /* invalidate I cache */
#endif
+
+#if !defined(CONFIG_SYS_DCACHE_OFF)
+ asm("mcr p15, 0, r1, c7, c14, 0"); /* Clean+invalidate D cache */
+#endif
+
+#endif /* CONFIG_ARM1136 */
+
#ifdef CONFIG_ARM926EJS
/* test and clean, page 2-23 of arm926ejs manual */
asm("0: mrc p15, 0, r15, c7, c10, 3\n\t" "bne 0b\n" : : : "memory");
/* disable write buffer as well (page 2-22) */
asm("mcr p15, 0, %0, c7, c10, 4" : : "r" (0));
-#endif
+#endif /* CONFIG_ARM926EJS */
return;
}
void flush_cache(unsigned long start, unsigned long size)
--
1.8.3.2
next prev parent reply other threads:[~2014-03-09 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 16:18 [U-Boot] [PATCH v2 0/5] ARM: refactor start.S files Albert ARIBAUD
2014-03-09 16:18 ` Albert ARIBAUD [this message]
2014-03-09 16:18 ` [U-Boot] [PATCH v2 2/5] arm: move reset_cpu from start.S into cpu.c Albert ARIBAUD
2014-03-09 16:18 ` [U-Boot] [PATCH v2 3/5] arm: pxa: move SP check from start.S to cpuinfo.c Albert ARIBAUD
2014-03-09 16:18 ` [U-Boot] [PATCH v2 4/5] arm: remove unused _end_vect and _vectors_end symbols Albert ARIBAUD
2014-03-09 16:18 ` [U-Boot] [PATCH v2 5/5] arm: move exception handling out of start.S files Albert ARIBAUD
2014-03-09 18:21 ` Andreas Bießmann
2014-03-09 19:04 ` Albert ARIBAUD
2014-03-09 22:19 ` [U-Boot] [PATCH v2 3/5] arm: pxa: move SP check from start.S to cpuinfo.c Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394381903-7007-2-git-send-email-albert.u.boot@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox