From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chin Liang See Date: Mon, 10 Mar 2014 18:17:02 -0500 Subject: [U-Boot] [PATCH v4 1/2] nand/denali: Adding Denali NAND driver support In-Reply-To: <20140310114244.6EF2.AA925319@jp.panasonic.com> References: <20140307215806.6EE0.AA925319@jp.panasonic.com> <1394207436.2749.18.camel@clsee-VirtualBox.altera.com> <20140310114244.6EF2.AA925319@jp.panasonic.com> Message-ID: <1394493422.3041.5.camel@clsee-VirtualBox.altera.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Mashiro, On Mon, 2014-03-10 at 11:42 +0900, Masahiro Yamada wrote: > Hello Chin, > > > > > I've posted my feedback. > > > I hope it is helpful for you. > > > http://patchwork.ozlabs.org/patch/327943/ > > > > > > > Great, I will patch them. > > From the patch, I saw your DMA sequence code and the discrepancy. > > For the data portion, I spotted you set the bit 31:16. > > But inside my datasheet, its marked as reserved. > > > > Wonder the version of Denali controller I have is older? > > Probably we can probe the Cadence then. > > At same time, I will send out new patch to capture the fix before > > forget. > > Yes, please. > > I am interested in this mystery. > I really suspect there are some > incompatible versions in Denali IP. > > I sent a question about this to Cadence. > They did not admit it. (But I doubt it.) > > > By the way, Panasonic have been using Denali > NAND controller IP since 2010. > I refer to "Denali NAND Flash Memory Controller User's Guide" > issued on Nov. 30, 2010. > Unfortunately, I can not share it because it is marked as > "confidential". Yup, me too. My one is having same title but dated Feb 28, 2011. I also checked the latest Feb 14, 2013 and it matched with 2011. Seems they changed in between 2010 and 2011. Wonder you have any newer version? To work around this, I presume we might to have some #if #else to separate the version differences. Thanks Chin Liang > > Best Regards > Masahiro Yamada. >