From: Jim Lin <jilin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 0/3] ubs: tegra: two fixes and cleanup
Date: Wed, 12 Mar 2014 21:57:33 +0800 [thread overview]
Message-ID: <1394632653.27402.13.camel@jilin-desktop> (raw)
In-Reply-To: <cover.1393785753.git.stefan@agner.ch>
On Mon, 2014-03-03 at 02:46 +0800, Stefan Agner wrote:
> Only patch 1 is an actual issue while the second patch is
> something I stumbled upon, and the third is more about
> housekeeping.
>
> I descieded to ifdef the driver, I think that this is easier to
> read and does not mix register access style. The function
> ehci_get_port_speed however don't get a pointer to the usb_ctlr
> struct and thouse has to work around that. I don't changed the
> register access style there because of this reason.
>
> The third patch is optional and implements Stephen's suggestion
> to merge the USB headers. I'm not sure wheater Tegra124 would
> also profit from this merge, if yes, I think then its definitely
> worth doing it.
>
> ---
> Changes since v4:
> - Merged Tegra124 USB header file as well
>
> Changes since v3:
> - Minor cleanup in USB header file
>
> Changes since v2:
> - Split into multiple patches
> - Using ifdef to account for differences between Tegra20/Tegra30
> - Merging of the header files
>
> Changes since v1:
> - Take differences between USBD and other USB ports into account
> port_sc1
>
> ---
> Stefan Agner (3):
> usb: tegra: fix USB2 powerdown for Tegra30 and later
> usb: tegra: fix PHY configuration
> usb: tegra: combine header file
>
> arch/arm/include/asm/arch-tegra/usb.h | 223 ++++++++++++++++++++++++-
> arch/arm/include/asm/arch-tegra114/usb.h | 156 ------------------
> arch/arm/include/asm/arch-tegra124/usb.h | 268 -------------------------------
> arch/arm/include/asm/arch-tegra20/usb.h | 155 ------------------
> arch/arm/include/asm/arch-tegra30/usb.h | 168 -------------------
> board/nvidia/common/board.c | 1 -
> drivers/usb/host/ehci-tegra.c | 28 +++-
> 7 files changed, 245 insertions(+), 754 deletions(-)
> delete mode 100644 arch/arm/include/asm/arch-tegra114/usb.h
> delete mode 100644 arch/arm/include/asm/arch-tegra124/usb.h
> delete mode 100644 arch/arm/include/asm/arch-tegra20/usb.h
> delete mode 100644 arch/arm/include/asm/arch-tegra30/usb.h
>
This series
Acked-by: Jim Lin <jilin@nvidia.com>
--nvpublic
prev parent reply other threads:[~2014-03-12 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 18:46 [U-Boot] [PATCH v5 0/3] ubs: tegra: two fixes and cleanup Stefan Agner
2014-03-02 18:46 ` [U-Boot] [PATCH v5 1/3] usb: tegra: fix USB2 powerdown for Tegra30 and later Stefan Agner
2014-03-03 17:12 ` Stephen Warren
2014-03-02 18:46 ` [U-Boot] [PATCH v5 2/3] usb: tegra: fix PHY configuration Stefan Agner
2014-03-02 18:46 ` [U-Boot] [PATCH v5 3/3] usb: tegra: combine header file Stefan Agner
2014-03-12 13:57 ` Jim Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394632653.27402.13.camel@jilin-desktop \
--to=jilin@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox